Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
@serhalp are you investigating? |
serhalp
left a comment
serhalp
left a comment
There was a problem hiding this comment.
🚀 LGTM, great find!
N=1 not very scientific but loading the netlify-cli page in prod vs. this branch took 130s vs. 15s 🎉
| const detailResults = await Promise.all( | ||
| vulnerablePackageInfos.map(pkg => queryOsvDetails(pkg)), |
There was a problem hiding this comment.
In egregious cases, this might fire off too many requests in parallel. Perhaps we could use a util here that limits concurrency to something like 25?
| } | ||
|
|
||
| return { status: 'ok', data: { name, version, depth, path, vulnerabilities, counts } } | ||
| return { |
There was a problem hiding this comment.
It looks like the batch endpoint is also paginated.
It seems unlikely we'd ever have incomplete results in the first page:
- An individual query within the queryset returns more than 1,000 vulnerabilities
- The entire queryset returns more than 3,000 vulnerabilities total
but maybe just check for a non-nil next_page_token and log a warning/error for future visibility?
garthdw
left a comment
garthdw
left a comment
There was a problem hiding this comment.
Feels faster on projen and @babel/core packages
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
4 participants
this updates osv analysis to use their batch api which significantly speeds up resolution for packages with large dep trees