Skip to content

chore: guard undefined values in uno-preset-rtl #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielroe merged 3 commits into from
Feb 2, 2026
Merged

chore: guard undefined values in uno-preset-rtl #696

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
366d99f
chore: add non-null assertions to uno preset
43081j Feb 1, 2026
2da3d1d
Merge remote-tracking branch 'origin/main' into jg/test-types-uno
danielroe Feb 2, 2026
84b336e
fix: handle undefined values
danielroe Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions uno-preset-rtl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ function directionSizeRTL(
const matcher = directionSize(propertyPrefix)
return (args, context) => {
const [match, direction, size] = args
if (!size) return undefined
const defaultMap = { l: 'is', r: 'ie' }
const map = prefixMap || defaultMap
const replacement = map[direction as 'l' | 'r']
Expand All @@ -41,19 +42,21 @@ function handlerRounded(
[, a = '', s = 'DEFAULT']: string[],
{ theme }: RuleContext<any>,
): CSSEntries | undefined {
if (a in cornerMap) {
if (s === 'full') return cornerMap[a].map(i => [`border${i}-radius`, 'calc(infinity * 1px)'])
const corners = cornerMap[a]
if (!corners) return undefined

const _v = theme.radius?.[s] ?? h.bracket.cssvar.global.fraction.rem(s)
if (_v != null) {
return cornerMap[a].map(i => [`border${i}-radius`, _v])
}
if (s === 'full') return corners.map(i => [`border${i}-radius`, 'calc(infinity * 1px)'])

const _v = theme.radius?.[s] ?? h.bracket?.cssvar?.global?.fraction?.rem?.(s)
if (_v != null) {
return corners.map(i => [`border${i}-radius`, _v])
}
}

function handlerBorderSize([, a = '', b = '1']: string[]): CSSEntries | undefined {
const v = h.bracket.cssvar.global.px(b)
if (a in directionMap && v != null) return directionMap[a].map(i => [`border${i}-width`, v])
const v = h.bracket?.cssvar?.global?.px?.(b)
const directions = directionMap[a]
if (directions && v != null) return directions.map(i => [`border${i}-width`, v])
}

/**
Expand All @@ -78,6 +81,7 @@ export function presetRtl(): Preset {
[
/^(?:position-|pos-)?(left|right)-(.+)$/,
([, direction, size], context) => {
if (!size) return undefined
const replacement = direction === 'left' ? 'inset-is' : 'inset-ie'
// oxlint-disable-next-line no-console -- warn logging
console.warn(
Expand All @@ -101,16 +105,18 @@ export function presetRtl(): Preset {
/^rounded-([rl])(?:-(.+))?$/,
(args, context) => {
const [_, direction, size] = args
if (!direction) return undefined
const replacementMap: Record<string, string> = {
l: 'is',
r: 'ie',
}
const replacement = replacementMap[direction]
if (!replacement) return undefined
// oxlint-disable-next-line no-console -- warn logging
console.warn(
`[RTL] Avoid using 'rounded-${direction}'. Use 'rounded-${replacement}' instead.`,
)
return handlerRounded(['', replacement, size], context)
return handlerRounded(['', replacement, size ?? 'DEFAULT'], context)
},
],
[
Expand Down
Loading