Skip to content

feat: add link to node modules inspector#73

Merged
danielroe merged 4 commits intonpmx-dev:mainfrom
Gugustinette:feat/add-link-to-node-modules-inspector
Jan 25, 2026
Merged

feat: add link to node modules inspector#73
danielroe merged 4 commits intonpmx-dev:mainfrom
Gugustinette:feat/add-link-to-node-modules-inspector

Conversation

@Gugustinette
Copy link
Copy Markdown
Contributor

@Gugustinette Gugustinette commented Jan 25, 2026

Resolves #52 by adding a link to Node Modules Inspector on packages.

Not sure if that's the best icon we could get from available sets, but a classic "file tree" icon might conflict with other part of the UI, which displays dependencies etc...

Also considering issues with having too much links displayed ? Maybe we could find another way to display all of these.

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 25, 2026

@Gugustinette is attempting to deploy a commit to the danielroe Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
npmx.dev Ready Ready Preview, Comment Jan 25, 2026 6:01pm

Request Review

@danielroe
Copy link
Copy Markdown
Member

in the interests of keeping it tiday, I think this could go next to the 'dependencies' heading in the right pane, with no icon

so:

Dependencies         Inspect

Comment thread app/pages/[...package].vue Outdated
target="_blank"
rel="noopener noreferrer"
class="link-subtle font-mono text-sm inline-flex items-center gap-1.5"
>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe:

Suggested change
>
title="Inspect dependency tree on node-modules.dev"
>

@serhalp
Copy link
Copy Markdown
Member

serhalp commented Jan 25, 2026

Works great, @Gugustinette!

in the interests of keeping it tiday, I think this could go next to the 'dependencies' heading in the right pane, with no icon

Screenshot 2026-01-25 at 12 18 33

@danielroe alternatively or in addition, it could make sense as a second icon here? https://npmgraph.js.org/ + node-modules.dev (+ any future ones we may add... though maybe we should keep the tool selection opinionated)

@Gugustinette
Copy link
Copy Markdown
Contributor Author

So here ?
Capture d’écran 2026-01-25 à 18 37 26

Here ?
Capture d’écran 2026-01-25 à 18 37 46

Or both ?

@danielroe
Copy link
Copy Markdown
Member

I was thinking the second one, but I think @serhalp is right - maybe a second icon next to the module graph

@Gugustinette
Copy link
Copy Markdown
Contributor Author

Ye I also like that second icon solution.

@danielroe danielroe merged commit 7a58de5 into npmx-dev:main Jan 25, 2026
7 checks passed
@Gugustinette Gugustinette deleted the feat/add-link-to-node-modules-inspector branch January 25, 2026 18:06
vinnymac pushed a commit to vinnymac/npmx.dev that referenced this pull request Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add link to node-modules-inspector

3 participants