Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Member
|
I think it doesn't make sense to search for nothing... I think the previous implementation is correct... |
Contributor
Author
|
@danielroe , that means when we click on search button, it should navigate to "/search" page ? That is what I've done now. |
Member
|
i'm saying it shouldn't navigate without a query the current behaviour is deliberate and the result of a pr merged earlier today |
Contributor
Author
|
i think our search is based on typing. But clicking a button is really tough after typing here. when we start typing, it automatically navigates to "/search" page. When the input field is empty, then the search button navigates to "/search" page after clicking the button. |
Contributor
Author
|
@danielroe , Oh I see. Then I close the pr. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our current implementation, search button is not even functional. (https://npmx.dev/). If we click on search button, it does nothing. I think we can keep the button if it does any work. I think in previous implementation I've seen when we click on search button, it navigates to "/search" page. So I make that thing.