fix: package docs responsiveness#839
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
📝 WalkthroughWalkthroughA CSS rule 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
@vrajpal-jhala thanks for the fix. I just tested the preview, the function name wrapping looks great now. However, it seems like there’s still some unexpected horizontal overflow. It’s causing the hamburger menu to shift to the far right of the page. I’ve attached a screen recording below so you can see exactly what’s happening. Screencast.from.03-02-26.06.22.03.PM.IST.webm |
Thanks for the quick review. I've noticed some more responsiveness issues. I'll spend some time and try to target them together. |
|
sounds like a plan, since you’re working on these responsiveness issues, could you convert PR status to 'Draft' for now? that way we’ll know it’s still a work in progress, and you can just mark it as 'Ready for Review' once you're happy with the final result. thanks again for the extra effort on this |
|
Unfortunately it's not good for accessibility to use scrollbars on blocks of code, because there are no clickable elements inside it and therefore cannot be interacted with. I know it doesn't look desirable design-wise, but the most accessible way to deal with this is just to wrap all code inside the block regardless. I wrote about this quite a few years ago and I still reference it. The most important part is here: https://whitep4nth3r.com/blog/how-to-make-your-code-blocks-accessible-on-your-website/#elements-that-have-scrollable-content-should-be-accessible-by-keyboard "Elements that have scrollable content should be accessible by keyboard" This is in reference to where you mentioned: "Added horizontal scrollbar for code blocks" |
That makes sense. Thank you for your inputs. I've updated the PR and the description accordingly. I believe this should fix the package docs page's responsiveness. |
|
I noticed svelte docs still wrap, due to a very long link |
60b7a34 to
f309b31
Compare
Great catch! It works now: https://npmx-mwxv95g5f-poetry.vercel.app/package-docs/svelte/v/5.49.1 I browsed few more popular packages and they don't have any issues. Please let me know! |

Minor css fixes to prevent horizontal scrollbars on mobile screens. Added word break for
codeblocks indtCloses #835