-
-
Notifications
You must be signed in to change notification settings - Fork 424
feat: allow toggle relative dates on click DateTime
#847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
9romise
wants to merge
10
commits into
npmx-dev:main
Choose a base branch
from
9romise:click-relative
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
dc47efe
feat(DateTime): click to toggle `relative`
9romise f2b5f33
refactor: unify `DateTime`
9romise 926cf19
test: cleanup test
9romise e7af59b
chore: add `type` for button
9romise b944119
chore: use composable
9romise 3d8a4be
Merge branch 'main' into click-relative
9romise a5f8164
chore: update
9romise f9f1e10
chore: update description
9romise ef4a6d6
Merge branch 'main' into click-relative
9romise a56e4dc
refactor: use `DateTimeButton`
9romise File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| <script setup lang="ts"> | ||
| /** | ||
| * refer to DateTime | ||
| */ | ||
| defineProps<{ | ||
| datetime: string | Date | number | ||
| title?: string | ||
| dateStyle?: 'full' | 'long' | 'medium' | 'short' | ||
| year?: 'numeric' | '2-digit' | ||
| month?: 'numeric' | '2-digit' | 'long' | 'short' | 'narrow' | ||
| day?: 'numeric' | '2-digit' | ||
| }>() | ||
|
|
||
| const { relativeDates, toggleRelativeDates } = useRelativeDates() | ||
| </script> | ||
|
|
||
| <template> | ||
| <button type="button" :aria-pressed="relativeDates" @click="toggleRelativeDates"> | ||
| <DateTime | ||
| :datetime="datetime" | ||
| :title="title" | ||
| :date-style="dateStyle" | ||
| :year="year" | ||
| :month="month" | ||
| :day="day" | ||
| /> | ||
| </button> | ||
| </template> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| import { mountSuspended } from '@nuxt/test-utils/runtime' | ||
| import { describe, it, expect, vi, beforeEach } from 'vitest' | ||
| import DateTimeButton from '~/components/DateTimeButton.vue' | ||
|
|
||
| // Mock the useRelativeDates composable | ||
| const mockRelativeDates = shallowRef(false) | ||
| vi.mock('~/composables/useSettings', () => ({ | ||
| useRelativeDates: () => ({ | ||
| relativeDates: mockRelativeDates, | ||
| }), | ||
| useSettings: () => ({ | ||
| settings: ref({ relativeDates: mockRelativeDates.value }), | ||
| }), | ||
| useAccentColor: () => ({}), | ||
| })) | ||
|
|
||
| describe('DateTimeButton', () => { | ||
| const testDate = '2024-01-15T12:00:00.000Z' | ||
|
|
||
| beforeEach(() => { | ||
| mockRelativeDates.value = false | ||
| }) | ||
|
|
||
| it('clicking button to toggle the relative dates settings', async () => { | ||
| const component = await mountSuspended(DateTimeButton, { | ||
| props: { datetime: testDate }, | ||
| }) | ||
| const button = component.find('button') | ||
|
|
||
| await button.trigger('click') | ||
| expect(button.attributes('aria-pressed')).toBe('true') | ||
|
|
||
| await button.trigger('click') | ||
| expect(button.attributes('aria-pressed')).toBe('false') | ||
| }) | ||
| }) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add
toggleRelativeDatesto the mock so clicks actually toggle.DateTimenow callstoggleRelativeDateson click, but the mock only providesrelativeDates, so the new interaction test cannot flip state and will fail.✅ Suggested fix
vi.mock('~/composables/useSettings', () => ({ useRelativeDates: () => ({ relativeDates: mockRelativeDates, + toggleRelativeDates: () => { + mockRelativeDates.value = !mockRelativeDates.value + }, }), useSettings: () => ({ settings: ref({ relativeDates: mockRelativeDates.value }), }), useAccentColor: () => ({}), }))📝 Committable suggestion