Skip to content

fix: light theme text visibility#861

Merged
danielroe merged 1 commit intonpmx-dev:mainfrom
iiio2:fix/light-theme-text-visibility
Feb 3, 2026
Merged

fix: light theme text visibility#861
danielroe merged 1 commit intonpmx-dev:mainfrom
iiio2:fix/light-theme-text-visibility

Conversation

@iiio2
Copy link
Copy Markdown
Contributor

@iiio2 iiio2 commented Feb 3, 2026

resolves #858

light dark

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 3, 2026 4:33pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 3, 2026 4:33pm
npmx-lunaria Ignored Ignored Feb 3, 2026 4:33pm

Request Review

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 3, 2026

📝 Walkthrough

Walkthrough

The Modal.client.vue component was updated to change the dialog text colour from a fixed white value (text-white) to a foreground colour class (text-fg). This modification involved altering a single line of code. The adjustment addresses text visibility concerns across different theme contexts without affecting the modal's layout or structural elements.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description references the linked issue #858 and includes visual comparisons showing the fix applied to the modal across light and dark themes.
Linked Issues check ✅ Passed The code change addresses the core requirement by changing text colour from white (text-white) to foreground colour (text-fg), which resolves visibility issues in both light and dark themes as specified in issue #858.
Out of Scope Changes check ✅ Passed The single-line change modifies only the Modal component's text styling to fix theme visibility, remaining within the scope of resolving issue #858 without introducing unrelated modifications.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@danielroe danielroe added this pull request to the merge queue Feb 3, 2026
Merged via the queue into npmx-dev:main with commit c108bcb Feb 3, 2026
15 checks passed
@iiio2
Copy link
Copy Markdown
Contributor Author

iiio2 commented Feb 3, 2026

Thanks. 😊

@iiio2 iiio2 deleted the fix/light-theme-text-visibility branch February 3, 2026 16:58
@shuuji3
Copy link
Copy Markdown
Member

shuuji3 commented Feb 3, 2026

Perfect! Thank you 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot read "What is an Atmosphere account?" text

3 participants