fix: light theme text visibility#861
Merged
danielroe merged 1 commit intonpmx-dev:mainfrom Feb 3, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
📝 WalkthroughWalkthroughThe Modal.client.vue component was updated to change the dialog text colour from a fixed white value (text-white) to a foreground colour class (text-fg). This modification involved altering a single line of code. The adjustment addresses text visibility concerns across different theme contexts without affecting the modal's layout or structural elements. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
danielroe
approved these changes
Feb 3, 2026
Contributor
Author
|
Thanks. 😊 |
Member
|
Perfect! Thank you 😀 |
This was referenced Feb 4, 2026
taskylizard
pushed a commit
to taskylizard/npmx.dev
that referenced
this pull request
Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #858