Skip to content

style: use logical properties#917

Merged
danielroe merged 2 commits intonpmx-dev:mainfrom
iiio2:style/use-logical-properties
Feb 4, 2026
Merged

style: use logical properties#917
danielroe merged 2 commits intonpmx-dev:mainfrom
iiio2:style/use-logical-properties

Conversation

@iiio2
Copy link
Copy Markdown
Contributor

@iiio2 iiio2 commented Feb 4, 2026

resolves #913

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 4, 2026 10:23am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 4, 2026 10:23am
npmx-lunaria Ignored Ignored Feb 4, 2026 10:23am

Request Review

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 4, 2026

📝 Walkthrough

Walkthrough

The pull request replaces physical CSS positioning utility classes with logical-property equivalents in three Vue components. In app/components/OgImage/Default.vue and app/components/OgImage/Package.vue -right-32 was changed to -inset-ie-32. In app/pages/package/[...package].vue left-0 was changed to inset-is-0. No other props, styles, structure or exported signatures were modified.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description directly references issue #913, which aligns with the changeset that replaces physical CSS properties with logical properties.
Linked Issues check ✅ Passed All three files have been modified to replace physical CSS properties (right-32, left-0) with their logical equivalents (inset-ie-32, inset-is-0), directly addressing the requirements specified in issue #913.
Out of Scope Changes check ✅ Passed All changes in the pull request are scoped to replacing physical CSS properties with logical properties as required by issue #913, with no unrelated modifications present.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

…perties

# Conflicts:
#	app/pages/package/[...package].vue
@danielroe danielroe added this pull request to the merge queue Feb 4, 2026
Merged via the queue into npmx-dev:main with commit f3eaedc Feb 4, 2026
16 checks passed
@iiio2
Copy link
Copy Markdown
Contributor Author

iiio2 commented Feb 4, 2026

Thanks.

@iiio2 iiio2 deleted the style/use-logical-properties branch February 4, 2026 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use logical properties for margin and padding

2 participants