Skip to content

fix: redundant mobile menu close logic #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielroe merged 1 commit into from
Feb 5, 2026
Merged

fix: redundant mobile menu close logic #992

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions app/components/AppHeader.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,19 +185,14 @@ onKeyStroke(
<HeaderAccountMenu />
</div>

<!-- Mobile: Menu button (always visible, toggles menu) -->
<!-- Mobile: Menu button (always visible, click to open menu) -->
<button
type="button"
class="sm:hidden flex items-center p-2 -m-2 text-fg-subtle hover:text-fg transition-colors duration-200 focus-visible:outline-accent/70 rounded"
:aria-label="showMobileMenu ? $t('common.close') : $t('nav.open_menu')"
:aria-expanded="showMobileMenu"
@click="showMobileMenu = !showMobileMenu"
:aria-label="$t('nav.open_menu')"
@click="showMobileMenu = true"
>
<span
class="w-6 h-6 inline-block"
:class="showMobileMenu ? 'i-carbon:close' : 'i-carbon:menu'"
aria-hidden="true"
/>
<span class="w-6 h-6 inline-block i-carbon:menu" aria-hidden="true" />
</button>
</div>
</nav>
Expand Down
Loading