EC GET fixes#4013
Merged
Merged
Conversation
cthulhu-rider
force-pushed
the
fix-ec-get
branch
3 times, most recently
from
ea460d0 to
1e12f2f
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4013 +/- ##
==========================================
- Coverage 27.73% 27.71% -0.03%
==========================================
Files 681 682 +1
Lines 46973 47019 +46
==========================================
+ Hits 13026 13029 +3
- Misses 32705 32746 +41
- Partials 1242 1244 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
cthulhu-rider
force-pushed
the
fix-ec-get
branch
from
58a3860 to
95c4df6
Compare
cthulhu-rider
requested review from
End-rey,
carpawell and
roman-khimov
as code owners
roman-khimov
approved these changes
Jun 16, 2026
Defect of 1f58293. Previously, buffer for object header passed to local storage for range reading was instantly freed. However, the resulting stream may include the buffer. Therefore, returning the buffer to the sync pool too early could lead to a data race. Now buffer is freed not earlier than data is copied completely. Refs #4012. Signed-off-by: Leonard Liubich <leonard@morphbits.io>
cthulhu-rider
force-pushed
the
fix-ec-get
branch
from
95c4df6 to
06bcb59
Compare
Defect of d25f426. Previously, in case of fallback to GET by chunk routines, they weren't synchronized request initialization and blocked to wait their turn to copy payload chunks. This could result in the chunks being streamed out of order. Refs #4012. Signed-off-by: Leonard Liubich <leonard@morphbits.io>
Defect of d25f426. Previously, buffer for object header passed to local storage for range reading was instantly freed. However, the resulting stream may include the buffer. Therefore, returning the buffer to the sync pool too early could lead to a data race. Now buffer is freed not earlier than data is copied completely. Refs #4012. Signed-off-by: Leonard Liubich <leonard@morphbits.io>
Omission of d25f426. Signed-off-by: Leonard Liubich <leonard@morphbits.io>
Break request handling when request context is done. Also do not log such errors. Signed-off-by: Leonard Liubich <leonard@morphbits.io>
Such cases are normal so do not worth log records. Signed-off-by: Leonard Liubich <leonard@morphbits.io>
Such requests are always sent from container nodes which have free access to GET data. Signed-off-by: Leonard Liubich <leonard@morphbits.io>
cthulhu-rider
force-pushed
the
fix-ec-get
branch
from
06bcb59 to
8f4f8eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #4012