Repository navigation
Drop VM ID from per-VM log - #131
Merged
Merged
Conversation
tmakatos
marked this pull request as draft
October 21, 2026 22:08
tmakatos
marked this pull request as ready for review
October 22, 2026 08:28
tmakatos
force-pushed
the
per-vm-log-drop-vm-id
branch
from
October 22, 2026 10:47
5011afb to
40b34bd
Compare
lforchini
approved these changes
Oct 22, 2026
lforchini
left a comment
lforchini
left a comment
Collaborator
There was a problem hiding this comment.
Would it be possible to add a tracing_subcriber::Layer which outputs to a per-vm file when there's a vm= entry or is that over-engineering it?
tmakatos
force-pushed
the
per-vm-log-drop-vm-id
branch
2 times, most recently
from
October 22, 2026 11:03
30cd216 to
40b34bd
Compare
Collaborator
Author
Added #150. |
Each VM's status line goes to its own file named after the VM, so repeating the VM ID on every line is redundant. AI-generated: everything Signed-off-by: Thanos Makatos <thanos.makatos@nutanix.com>
tmakatos
force-pushed
the
per-vm-log-drop-vm-id
branch
from
October 22, 2026 11:41
40b34bd to
d255a7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each VM's status line goes to its own file named after the VM, so
repeating the VM ID on every line is redundant.
AI-generated: everything
Signed-off-by: Thanos Makatos thanos.makatos@nutanix.com
Stack created with GitHub Stacks CLI • Give Feedback 💬