TW-5009: centralize API base URL resolution to respect api.base_url config#81
Merged
Merged
Conversation
…onfig Adds Config.ResolveBaseURL() and HTTPClient.ApplyConfig() to replace scattered SetRegion/SetBaseURL patterns, ensuring all API calls honor the api.base_url config when set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Config.ResolveBaseURL()in the domain layer to centralize base URL resolution logic (api.base_url> region > US default)HTTPClient.ApplyConfig()as a single entry point replacing scatteredSetRegion()/SetBaseURL()if/else blocks across 10+ call sitesnylas doctornetwork check to respect configured base URL instead of hardcodingapi.us.nylas.comTest plan
ResolveBaseURL()— US default, EU region, custom base URL precedence, empty/nil edge casesApplyConfig()— nil config no-op, region selection, custom URL overridenylas doctorreports correct connectivity against configured base URLnylas auth loginandnylas initwork withapi.base_urlset in configapi.base_urlis configuredRelated docs