Repository navigation
fix(generator): resolve log generator identity at construction - #333
Merged
Merged
Conversation
eKuG
approved these changes
Oct 16, 2026
Dylan-M
force-pushed
the
dylanmyers/log-generator-identity-seam
branch
2 times, most recently
from
October 16, 2026 15:02
6700b12 to
2222b25
Compare
Dylan-M
added this pull request to stack #337
October 16, 2026 15:04
Dylan-M
force-pushed
the
dylanmyers/log-generator-identity-seam
branch
from
October 16, 2026 15:30
2222b25 to
4f3e2e7
Compare
…ment Assisted-By: Claude Opus 5.5
…ves SetHostIdentity, use generator.WithIdentity or Config.Identity Assisted-By: Claude Opus 5.5
Assisted-By: Claude Opus 5.5
Assisted-By: Claude Opus 5.5
Assisted-By: Claude Opus 5.5
…optional vendor Assisted-By: Claude Opus 5.5
eKuG
requested changes
Oct 16, 2026
Comment on lines
+102
to
+106
| domain (`pa-fw-01.blitz.local`) that a device's syslog header carries. Each | ||
| appliance generator entry gets its own device: when the random fleet holds | ||
| fewer devices of a vendor than the entries need, the environment appends the | ||
| rest, deterministically per seed and without moving any drawn device, so every | ||
| entry describes a real device of its own. PAN-OS devices run an 11.0.x release, |
There was a problem hiding this comment.
Two flow generator entries can end up on the same exporting device. This happens when an entry with no exporterVendor is mixed with entries pinned to a vendor.
This contradicts the docs. According to code, two entries send records with the same exporter address, so a collector merges them into one device.
…ype entries Assisted-By: Claude Opus 5.5
…evices Assisted-By: Claude Opus 5.5
Assisted-By: Claude Opus 5.5
Assisted-By: Claude Opus 5.5
Dylan-M
force-pushed
the
dylanmyers/log-generator-identity-seam
branch
from
October 16, 2026 18:36
4f3e2e7 to
2c24ffc
Compare
eKuG
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Change
Log generators now get their simulated host when they're built.
docs/environment.mdhas the selection rules, anddocs/embed.mdthe new API for embedders.Checklist