frontend: Make CropItem anchor logic stateless#13508
Open
feeqra wants to merge 2 commits into
Open
Conversation
Uses an existing helper function to replace the manual stateful calculation of the stretch item's anchor point with a stateless calculation based on the final size of the stretch item. Reduces code complexity and redundancy. Improves readability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses an existing helper function to replace the manual stateful calculation of the stretch item's anchor point with a stateless calculation based on the final size of the stretch item. Reduces code complexity and redundancy. Improves readability.
Description
The original logic determines the stretch-item's new anchor point position using the mouse's state. This isn't necessary as this new position can be calculated from the stretch-item's final dimensions.
Motivation and Context
Removes redundant logic that was already handled by the helper function. Improves readability.
How Has This Been Tested?
OS: Ubuntu
Hardware: Local WSL build environment
Manual testing steps:
altand dragged all 4 edges and 4 corners independently.Types of changes
Code cleanup (non-breaking change which makes code smaller or more readable)
Checklist: