Repository navigation
fix via route test - #365
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The via test claimed to check that every trip passes the via stop, but it searched for the destination stop instead, so it could never fail.
Checking the actual via stop fails reliably against the live WebAPI. The API also accepts a trip through a nearby stop: asked to route via Hauptbahnhof, most trips pass Hauptbahnhof Nord and never stop at Hauptbahnhof. The test now only checks that a via request returns trips, and a comment explains why.
The vvo docs describe
viaonly as a stop ID for an intermediate waypoint. The EFA interface docs list auseProxFootSearchoption ("consider nearby stops") that may explain this, but it is not confirmed to apply tovia.