Skip to content

chore: fix: finalize was missing from the octx context#799

Open
Skarlso wants to merge 7 commits into
open-component-model:mainfrom
Skarlso:memory-leak-investigation
Open

chore: fix: finalize was missing from the octx context#799
Skarlso wants to merge 7 commits into
open-component-model:mainfrom
Skarlso:memory-leak-investigation

Conversation

@Skarlso

@Skarlso Skarlso commented Dec 11, 2025

Copy link
Copy Markdown
Contributor

What this PR does / why we need it

Testable ghcr.io/open-component-model/ocm-controller:v0.28.0-memory-leak-test-1

Closes open-component-model/ocm-project#778.

Which issue(s) this PR is related to

frewilhelm
frewilhelm previously approved these changes Dec 11, 2025
morri-son
morri-son previously approved these changes Jan 26, 2026
@Skarlso Skarlso changed the title fix: finalize was missing from the octx context **DO NOT MERGE THIS YET**: fix: finalize was missing from the octx context Feb 2, 2026
@Skarlso Skarlso changed the title **DO NOT MERGE THIS YET**: fix: finalize was missing from the octx context DO NOT MERGE THIS YET: fix: finalize was missing from the octx context Feb 2, 2026
@Skarlso Skarlso marked this pull request as draft February 2, 2026 11:17
@Skarlso Skarlso force-pushed the memory-leak-investigation branch from e1d5ff3 to d7e20af Compare April 14, 2026 06:53
@Skarlso Skarlso force-pushed the memory-leak-investigation branch from c1eece8 to 6690057 Compare June 1, 2026 08:15
Skarlso added 6 commits June 24, 2026 09:21
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com>

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com>

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com>

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com>

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com>

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@Skarlso Skarlso force-pushed the memory-leak-investigation branch from 6690057 to ae1f5ab Compare June 24, 2026 07:27
@Skarlso Skarlso changed the title DO NOT MERGE THIS YET: fix: finalize was missing from the octx context chore: fix: finalize was missing from the octx context Jun 25, 2026
@Skarlso Skarlso marked this pull request as ready for review June 25, 2026 08:28
Comment thread go.mod

replace github.com/ThalesIgnite/crypto11 => github.com/ThalesGroup/crypto11 v1.6.0

replace ocm.software/ocm => github.com/Skarlso/ocm v0.0.0-20260420070955-22d2eada8ccc

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to replace this one once the other one is fixed and merged and released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

memory leak in ocm controller 0.27.3

3 participants