Repository navigation
Conversation
Contributor
|
Pull request dashboard statusWaiting on maintainers · refreshed 2026-10-19 19:33 UTC Merge when ready. Status above doesn't look right?
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8929 +/- ##
============================================
- Coverage 90.40% 90.40% -0.01%
- Complexity 10898 10903 +5
============================================
Files 1015 1016 +1
Lines 29843 29852 +9
Branches 3896 3897 +1
============================================
+ Hits 26981 26989 +8
Misses 1910 1910
- Partials 952 953 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rooks-ns
marked this pull request as ready for review
October 10, 2026 14:33
jack-berg
reviewed
Oct 16, 2026
rooks-ns
force-pushed
the
fix/avoid-shared-internal-encoding-utils
branch
from
October 16, 2026 22:53
4b98633 to
e9759fd
Compare
- Restrict api.impl to cross-module callers and remove @SInCE - Retain api.internal for trace primitives
rooks-ns
force-pushed
the
fix/avoid-shared-internal-encoding-utils
branch
from
October 16, 2026 23:16
e9759fd to
b644804
Compare
…internal OtelEncodingUtils
Member
|
FYI, I pushed a commit to address a few lingering concerns:
|
jack-berg
approved these changes
Oct 19, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #6970.
Promotes
OtelEncodingUtilsfromio.opentelemetry.api.internaltoio.opentelemetry.api.implto eliminate cross-artifact internal package sharing across 5 downstream modules, and unexemptsopentelemetry-sdk-profilesinNoSharedInternalCodeTest.Changes
OtelEncodingUtils: Moved fromio.opentelemetry.api.internaltoio.opentelemetry.api.implin:api:all.:api:all,:sdk:profiles,:sdk:trace,:exporters:common,:exporters:otlp:common,:exporters:otlp:profiles, and:sdk-extensions:incubator.NoSharedInternalCodeTest: Removedopentelemetry-sdk-profilesfrom exemptions.