Skip to content

Drop ASM dependency from NullGaurdsTest - #8954

Merged
jack-berg merged 3 commits into
open-telemetry:mainfrom
jack-berg:drop-asm-dependency
Oct 19, 2026
Merged

jack-berg merged 3 commits into
open-telemetry:mainfrom
jack-berg:drop-asm-dependency

Conversation

@jack-berg

Copy link
Copy Markdown
Member

Now that we use java 25 for the build, we can drop the asm dependency and in favor of built in java.lang.classfile.* classes.

@jack-berg
jack-berg requested a review from a team as a code owner October 16, 2026 20:15
@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Pull request dashboard status

Merged · refreshed 2026-10-19 19:43 UTC

Status above doesn't look right?
  • Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

@codecov

codecov Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.42%. Comparing base (b32298a) to head (f719d59).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8954      +/-   ##
============================================
+ Coverage     90.40%   90.42%   +0.01%     
- Complexity    10898    10901       +3     
============================================
  Files          1015     1015              
  Lines         29843    29843              
  Branches       3896     3896              
============================================
+ Hits          26981    26985       +4     
+ Misses         1910     1909       -1     
+ Partials        952      949       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread all/src/test/java/io/opentelemetry/all/NullGuardsTest.java
@jack-berg
jack-berg merged commit 210b0a9 into open-telemetry:main Oct 19, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants