Repository navigation
Conversation
Pull request dashboard statusWaiting on the author · refreshed 2026-10-19 00:48 UTC Move out of draft to request review. Status above doesn't look right?
|
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (40.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #8967 +/- ##
============================================
- Coverage 90.40% 90.40% -0.01%
Complexity 10898 10898
============================================
Files 1015 1015
Lines 29843 29850 +7
Branches 3896 3899 +3
============================================
+ Hits 26981 26986 +5
- Misses 1910 1911 +1
- Partials 952 953 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8966
Related to #8854, #6614
Description
RetryInterceptorintoOkHttpGrpcSender.sendAttempt()and dropped them.RetryInterceptorandJdkHttpSender:Attempt N failed with (non-)retryable exception(exception passed as theThrowable) andAttempt N returned (non-)retryable response: ....Responseis no longer at hand.RetryInterceptordoes the same.OkHttpGrpcSenderinstead ofRetryInterceptor(same package).Testing done
OkHttpGrpcSenderTest#send_retryEnabled_logsEachFailedAttempt: closed port, 2 attempts; expectsAttempt 0 ...andAttempt 1 failed with retryable exception../gradlew :exporters:sender:okhttp:checkpassed, 57 tests.internalpackage, no apidiff change.