Skip to content

Retry Copilot errors once before releasing the review gate - #477

Merged
trask merged 2 commits into
mainfrom
trask-dashboard-review-recovery
Oct 16, 2026
Merged

trask merged 2 commits into
mainfrom
trask-dashboard-review-recovery

Conversation

@trask

@trask trask commented Oct 16, 2026 •

Copy link
Copy Markdown
Member

Treat Copilot's "encountered an error" notice as a failed attempt rather than a completed review, allowing one automatic retry per commit. After a second error notice, stop requests for that commit and release the Copilot gate. Required checks and unresolved Copilot findings still apply.

Retry on the next eligible refresh without requiring a new commit, including for PRs already routed to reviewers. A new commit resets the budget, and the status comment explains when retries stop.

Observed on open-telemetry/opentelemetry-java-instrumentation#20633.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 9801bd91-91e6-4ba3-994f-a6c6212a360a
@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Pull request dashboard status

Merged · refreshed 2026-10-16 23:51 UTC

Status above doesn't look right?
  • Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused change has relevant regression coverage and no identified blocking issues.

0 open findings

What changed in this PR

Treats Copilot error notices as failed attempts so the dashboard can retry reviews without a new commit.

Changes:

  • Excludes exact error notices from completed-review status.
  • Adds regression coverage for retries, delivery confirmation, and routing.
  • Documents retry behavior and unchanged safeguards.
File Description
pull-request-dashboard/​README.md Documents retries and gate timeout behavior.
.github/​scripts/​pull-request-dashboard/​test_dashboard.py Tests same-head retries across existing routes.
.github/​scripts/​pull-request-dashboard/​test_copilot_review.py Tests error classification and delivery behavior.
.github/​scripts/​pull-request-dashboard/​RATIONALE.md Explains failed-attempt handling and safeguards.
.github/​scripts/​pull-request-dashboard/​copilot_review.py Filters error notices from completed reviews.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Stop automatic requests and release the Copilot gate after two error notices on the current head. Keep required checks and unresolved findings blocking, and explain exhausted retries in the live status.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: a1dc5421-f8bf-4a1d-bafa-ae90bad468af
@trask trask changed the title Retry Copilot reviews after error notices Retry Copilot errors once before releasing the review gate Oct 16, 2026
@trask
trask marked this pull request as ready for review October 16, 2026 03:58
@trask
trask requested a review from a team as a code owner October 16, 2026 03:58
@trask
trask requested review from maryliag and a balanced review from Copilot October 16, 2026 03:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The bounded retry behavior and delivery safeguards preserve existing routing blockers, with no unresolved issues identified.

0 open findings

🧠 Review effort: Balanced

@trask
trask merged commit 90ab223 into main Oct 16, 2026
7 checks passed
@trask
trask deleted the trask-dashboard-review-recovery branch October 16, 2026 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants