Repository navigation
Use normal author-reply handoffs for Copilot feedback - #482
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0a92f342-8ad1-4f64-aefd-f92558fb8a66
Pull request dashboard statusMerged · refreshed 2026-10-18 23:40 UTC Status above doesn't look right?
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes reuse established discussion routing, preserve current-head gating, and include focused regression coverage with no identified blockers.
No open issues 🎉
What changed in this PR
Aligns Copilot feedback with the dashboard’s normal author-reply handoffs while preserving current-head review requirements.
Changes:
- Routes completed replies back to reviewers; keeps promised work with authors.
- Separates review freshness from unresolved-thread tracking.
- Updates regression coverage, documentation, and status-comment rollout.
| File | Description |
|---|---|
| pull-request-dashboard/README.md | Documents shared feedback handoff rules. |
| .github/scripts/pull-request-dashboard/test_state.py | Checks the updated comment revision. |
| .github/scripts/pull-request-dashboard/test_discussion_lifecycle.py | Removes the strict-ownership assertion. |
| .github/scripts/pull-request-dashboard/test_dashboard.py | Covers handoffs, renewed feedback, and stale-review gating. |
| .github/scripts/pull-request-dashboard/test_copilot_review.py | Updates review-status expectations. |
| .github/scripts/pull-request-dashboard/test_classification_policy.py | Verifies normal reply-policy handling. |
| .github/scripts/pull-request-dashboard/test_classification_execution.py | Covers completed replies, deferrals, and classification failures. |
| .github/scripts/pull-request-dashboard/state.py | Increments the status-comment revision. |
| .github/scripts/pull-request-dashboard/RATIONALE.md | Explains shared routing and independent review gating. |
| .github/scripts/pull-request-dashboard/pull_request_evaluation.py | Uses discussion actions for feedback links and routing. |
| .github/scripts/pull-request-dashboard/discussion_lifecycle.py | Removes forced author ownership. |
| .github/scripts/pull-request-dashboard/dashboard.py | Updates the review-needed field documentation. |
| .github/scripts/pull-request-dashboard/copilot_review.py | Removes thread counting from review status. |
| .github/scripts/pull-request-dashboard/copilot_review_delivery.py | Adapts delivery checks to simplified review status. |
| .github/scripts/pull-request-dashboard/classification_policy.py | Applies ordinary discussion rules to Copilot feedback. |
Review effort: Balanced
maryliag
approved these changes
Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Treat author replies to Copilot feedback the same as replies to human reviewers. For example, "Added the regression test" hands the action back to reviewers without requiring Resolve conversation; a promise to do more work keeps it with the author.
The current-head Copilot review requirement stays in place. Open threads remain visible as unresolved feedback, but the author status links only threads that still need author action. A later clean review alone does not clear unanswered feedback.
This addresses the already-answered thread on open-telemetry/opentelemetry-java-instrumentation#20528.