Repository navigation
Display log messages from Forklift version checks - #316
Merged
Merged
Conversation
…L fields, not comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if the Forklift version checks emitted an error, a log message would be added to
/run/versioning/forklift.ymlas a YAML comment, and machine-admin wouldn't be able to display it. Those messages are very important - for example, the warning that the OS booted into the previously-booted pallet, because the pending pallet failed to be started correctly. This PR saves those log messages into lists of strings in the Forklift versioning YAML file, and bumps machine-admin to a version which displays those messages.This PR integrates openUC2/machine-admin#63 .