soc_VWID/VWEUDA: improvements#3548
Merged
Merged
Conversation
…rove field parsing logging
LKuemmel
requested changes
Jun 16, 2026
Comment on lines
+855
to
+862
| topic = f"openWB/vehicle/{vehicle}/soc_module/config" | ||
| conf = os.popen(f"mosquitto_sub -C 1 -t {topic}").read() | ||
| _LOGGER.debug(f"thread loop: conf={conf}") | ||
| _type = json.loads(conf)['type'] | ||
| _LOGGER.info(f"thread loop: _type={_type}") | ||
| if _type != 'vwid': | ||
| _LOGGER.info(f"vehicle {vehicle} is not using module vwid: terminate now") | ||
| return |
Contributor
There was a problem hiding this comment.
Dieser Code ist eher ein Workaround und zeigt, dass while True keine saubere Lösung ist. Gibt es eine andere Lösung für das Thread-Handling, konsistent zum restlichen Code?
Collaborator
Author
There was a problem hiding this comment.
HalloLena, Ich mache das noch schöner, Kann ich die Config des EV bzw. dessen SoC-Modul Config intern abfragen?
Das "while True" werde ich durch eine bessere Bedingung erstzen aber momentan fehlt mir die Zeit.
Es wäre schön wenn es erst mal gemerged würde damit die Tester weitermachen können.
Contributor
There was a problem hiding this comment.
Das SoC-Modul soll möglichst unabhängig von der Fahrzeug-Klasse Ev sein.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@LKuemmel , please merge ASAP, thanks!