Repository navigation
ci(invoice): separate scheduled evaluation from PR checks - #1895
Conversation
cd8f8c9 to
fffac24
Compare
alandelong-oai
left a comment
There was a problem hiding this comment.
Thanks for separating published-CLI evaluation from routine PR checks. No blocking findings in this owner-level merge-safety and simplification review. Manual exact-head scans and weekly main baselines retain the protected workflow, environment approval, source rechecks, and credential boundaries. One nonblocking documentation suggestion is inline.
At this rebased head, all 36 sample/helper tests and all nine mocked workflow tests passed, along with actionlint/ShellCheck, zizmor, formatting, and diff checks. The six-file change and its orchestration/test inputs are unchanged from the previous review. No credentialed inference, live scheduling, or environment-approval transition was run; those behaviors activate from protected main.
alandelong-oai
left a comment
There was a problem hiding this comment.
Thanks for updating the baseline instructions. This owner-level merge-safety review found no issues: the README now directs maintainers to the supported manual workflow on main with the PR number and exact head SHA, resolving the earlier suggestion.
Only the README changed. Formatting, whitespace and all seven local links passed; the workflow name and input names match the implementation. Prior runtime/workflow checks remain applicable to identical source and dependency inputs and were not repeated. No live inference or dispatch was run.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e2613660a3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
e261366 to
0177c75
Compare
alandelong-oai
left a comment
There was a problem hiding this comment.
Thanks for tightening cancellation and updating the guides. I found no material issues at 0177c752: rejected requests cannot reach the scan concurrency group, and different source revisions remain isolated while protected-main and post-approval eligibility checks stay intact.
Fresh validation passed: 36 sample/helper cases on Node 22.13.0, 28 mocked workflow/quality cases on Bun 1.3.14, SDK/MCP type and generation checks, actionlint/ShellCheck, configured zizmor, formatting, and 21 local documentation links.
No live inference, workflow dispatch, scheduled run, or hosted approval/cancellation transition was exercised. Broad runtime/native suites were not run, and hosted CI was still in progress.
Summary
Invoice Desk currently launches inference orchestration for routine PR updates even though it evaluates the sample with a pinned published CLI. Run that evaluation manually or on a weekly main baseline, and keep deterministic PR checks focused on changes to the sample and its helpers.
Changes
Testing
Review target:
0177c7523049398cdcb5772f0ed108e4a2562c35, based on mainb3448fc0ad5faeec6bdb1e96b1f99828cce6ac7b. Three fresh native reviews and an independent verifier passed on this exact head with no findings.node --test .github/scripts/invoice-desk-target.test.mjs .github/scripts/invoice-desk-source.test.mjs— 16 passed on the final repair. The preceding workflow/documentation repair also passed all 36 tests when includingexamples/invoice-desk/qa/app.test.mjs.sdk/typescript:bun test --timeout 30000 tests-ts/invoice-desk-workflow.test.ts— 10 passed, including the actual workflow's validated-target and exact-revision cancellation regression. A comparison against the previous workflow confirms different revisions no longer share a group.sdk/typescript:bun test --timeout 30000 tests-ts/workflow-quality.test.ts— 18 passed before the final exact-revision group adjustment.0177c7523049398cdcb5772f0ed108e4a2562c35head: 49 successful jobs and one intentional skip on attempt 1, including the cancellation and guide repairs.b4741b89f26666a5375899f2c2be6a068bef3465, based on mainb3448fc0ad5faeec6bdb1e96b1f99828cce6ac7b: node-ci passed all 64 jobs and Action CI passed all three jobs, both on attempt 1.4bbbb61a8948445661db7a30f24299aae9deb2d8, based on5c8a8d662fb5f207fd5dc1ff3bc9197e6e8d629b. Fixed seed12345and recorded random seed1267795626each produced 6,996 passes, 83 skips, zero failures, and 101,231 assertions. These full-suite results and the later combined hosted graph are separate source snapshots.Risk and rollout
Automatic inference on each PR update is intentionally removed. Maintainers can explicitly evaluate an open PR by supplying its exact current head SHA, and weekly baselines evaluate main. This is not a required merge check; no branch-protection settings or public CLI interfaces change.
Protected-main execution, environment approval, exact-source checks before and after approval, committed-blob extraction, removal of the answer key before inference, and read-only scan cache access are preserved. The changed triggers and schedule take effect after this workflow reaches main. Existing environment approval/wait policies still apply to scheduled runs. Different revisions intentionally retain separate approval requests; stale pending requests can be cancelled manually and skip inference after approval if their PR revision is no longer eligible. Hosted approval and duplicate cancellation remain operational validation items after deployment.
Public disclosure review