Repository navigation
fix(plugin): declare app connections optional - #2100
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
mldangelo-oai
approved these changes
Oct 28, 2026
mldangelo-oai
left a comment
Collaborator
There was a problem hiding this comment.
Good change. Can you also add a line to the AGENTS.md about this
Collaborator
|
Thanks! Please reach out if you would like some swag! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Declare the plugin's connected apps as optional. Local scans do not require a Cloud, Linear, GitHub, or Atlassian connection.
Changes
required: falseon each app entry.Testing
On the merge with main at
b3853f1f, Python lint and formatting, the CI TypeScript build, plugin source compatibility, and all nine compatibility checker tests passed. The focused Python tests passed eight cases and eight subtests. The bundled plugin built successfully and both SDK plugin-app tests passed.Risk and rollout
This makes the optional app contract explicit. It preserves the app IDs, available integrations, and existing permissions. It does not change the client logic that chooses an Open plugin destination.
Public disclosure review