Skip to content

fix(plugin): declare app connections optional - #2100

Merged
mldangelo-oai merged 3 commits into
mainfrom
fix/optional-plugin-apps
Nov 3, 2026
Merged

mldangelo-oai merged 3 commits into
mainfrom
fix/optional-plugin-apps

Conversation

@ianw-oai

@ianw-oai ianw-oai commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Declare the plugin's connected apps as optional. Local scans do not require a Cloud, Linear, GitHub, or Atlassian connection.

Changes

  • Set required: false on each app entry.
  • Require the explicit flag in source and bundled-plugin contract tests.
  • Clarify when users need to connect an app and document the optional manifest setting in the contributor instructions.

Testing

On the merge with main at b3853f1f, Python lint and formatting, the CI TypeScript build, plugin source compatibility, and all nine compatibility checker tests passed. The focused Python tests passed eight cases and eight subtests. The bundled plugin built successfully and both SDK plugin-app tests passed.

Risk and rollout

This makes the optional app contract explicit. It preserves the app IDs, available integrations, and existing permissions. It does not change the client logic that chooses an Open plugin destination.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@github-actions github-actions Bot added the bug Something isn't working label Oct 28, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-11-02T20:03:03.601994Z 10e6ab3 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@ianw-oai ianw-oai self-assigned this Oct 28, 2026

@mldangelo-oai mldangelo-oai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change. Can you also add a line to the AGENTS.md about this

@mldangelo-oai
mldangelo-oai merged commit af678d2 into main Nov 3, 2026
126 of 129 checks passed
@mldangelo-oai
mldangelo-oai deleted the fix/optional-plugin-apps branch November 3, 2026 19:47
@mldangelo-oai

Copy link
Copy Markdown
Collaborator

Thanks! Please reach out if you would like some swag!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants