Repository navigation
Allow componentConsole to be a function - #1584
Open
leandrowilliam wants to merge 2 commits into
Open
leandrowilliam wants to merge 2 commits into
leandrowilliam wants to merge 2 commits into
Conversation
Lets the registry expose a console (or a console-like logger that forwards to a monitoring provider) to components' server-side code outside of `oc dev`. Defaults are unchanged: real console when local, no-op otherwise. Closes opencomponents#1464
Lets the registry return a console per component, so logs can be tagged with the component name and version. Closes opencomponents#1583
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1583
Builds on #1465
componentConsolecan now also be a function. The registry calls it with the component'snameandversionand uses the console it returns, so logs can be tagged per component:Passing a plain console object works as before. The function is only called when the component's server code is loaded, not on every request.