Add support for handling hop-by-hop packets in Lucius#698
Open
tejatamboli02 wants to merge 1 commit into
Open
Conversation
Contributor
|
/gcbrun |
Contributor
|
/gcbrun |
Contributor
|
/gcbrun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This diff ensures that Hop-by-Hop packets are no longer prematurely dropped as malformed by the parser. Instead, it allows them into the pipeline where it installs explicit rules to drop unicast Hop-by-Hop packets while permitting multicast Hop-by-Hop packets to continue.
table.go: A WithPriority(priority uint32) method was added to the FlowEntryBuilder. The dataplane uses flow tables to match packets against rules. Because the new Hop-by-Hop rules need to distinguish between multicast and unicast packets, the rules need explicit priorities to ensure the switch evaluates them in the correct order.
switch.go: In the createInvalidPacketFilter function, it uses the new WithPriority API to install specific Hop-by-Hop filtering rules into the IPv6 invalid ingress table (invalidIngressV6Table). It applies 3 rules Existing invalid prefix rule (Priority 20), Rule 1 - Multicast Hop-by-Hop (Priority 10), Rule 2 - Unicast Hop-by-Hop (Priority 5).