fix(watcher): sanitize tenant_id in asyncio task and thread names#106
Merged
Conversation
Strip non-printable characters from tenant_id before embedding it in the asyncio task name (async_watcher) and threading.Thread name (watcher). A module-level compiled regex removes everything outside the printable ASCII range (0x20–0x7E), so user-controlled tenant IDs containing control characters no longer propagate into task/thread names. Closes #70 Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tenant_idverbatim, allowing user-controlled control characters to appear inasynciotask names andthreading.Threadnames.Test plan
test_thread_name_sanitizes_control_chars— verifies sync watcher strips\x00and\x1ffrom thread nametest_task_name_sanitizes_control_chars— verifies async watcher strips same chars from asyncio task nameCloses #70