Skip to content

Bound watched field change queues#109

Draft
Mirochill wants to merge 1 commit into
opendecree:mainfrom
Mirochill:fix-100-bound-watched-field-queue
Draft

Bound watched field change queues#109
Mirochill wants to merge 1 commit into
opendecree:mainfrom
Mirochill:fix-100-bound-watched-field-queue

Conversation

@Mirochill
Copy link
Copy Markdown

Summary

  • Bound sync and async watched-field change queues with a default capacity of 1024.
  • Drop the oldest buffered change when a slow consumer lets the queue fill, and expose dropped_changes on watched fields.
  • Add regression coverage for sync and async queue overflow behavior and max_queue_size wiring.

Related issues

Closes #100

Test plan

  • git diff --check
  • git diff --cached --check
  • git show --check HEAD
  • make lint passes
  • make typecheck passes
  • make test passes

Not run locally: make lint, make typecheck, make test.

Checklist

  • SDK regenerated if proto changed in decree (not applicable)
  • Breaking change flagged in title/description if applicable (not applicable)
  • Changelog/release note added if applicable (not applicable)

@github-actions
Copy link
Copy Markdown

Thanks for your first pull request! We appreciate the contribution.

Before review, please make sure tests pass: cd sdk && pytest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bound WatchedField change queue to prevent memory growth

1 participant