Repository navigation
Update Java and CORS template docs - #362
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
447e36c to
396e627
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
396e627 to
9769a72
Compare
This comment has been minimized.
This comment has been minimized.
9769a72 to
4ccff05
Compare
This comment has been minimized.
This comment has been minimized.
Refresh the Java walkthrough so it matches the current templates and works end to end. The templates now use Eclipse Temurin on Ubuntu 24.04 Noble, while the article still referenced older base images, repositories, handler contracts, dependencies, and external services. - Document the Temurin/Noble base images and Maven Central. - Use Gradle declarations compatible with each template runtime. - Align handler types and generated YAML filenames with current faas-cli output. - Replace the unavailable quote service and refresh tested examples. - Correct the java11-vert-x template name in the CORS guide. Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
Align the homepage Java 11 snippet with the current template and entrypoint contract. Implementing IHandler directly causes the entrypoint to reject the handler at runtime because it expects an AbstractHandler subtype. Extend com.openfaas.model.AbstractHandler explicitly so the displayed example matches the generated template and runs correctly. Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
4ccff05 to
889a4ee
Compare
AI Pull Request OverviewDisclaimer: This review was generated by automated AI and may contain errors. Do not trust its outputs without human verification. Summary
Approval rating (1-10)7/10. The scope is useful, but the Java tutorial still contains a dependency syntax regression that can break readers following the updated steps. Summary per fileSummary per file
Overall AssessmentThe PR moves stale documentation in the right direction and fixes several outdated references. However, the updated Java tutorial still tells readers to add OkHttp dependencies with Gradle's removed Detailed ReviewDetailed ReviewContent reviewMedium: Java tutorial still uses removed Gradle
|
The blog post is correct the Java11 template uses an older Gradle version. Question is if the template should be modernized. |
|
A newer Java template is worth creating - but I would imagine it'd be vert-x only not Java 11 which is very old at this point.
That'd be a new template, triaged on Trello and managed properly, with updated/latest vert-x patterns and version. Gradle again too - but updated. |
Description
Update the Java OpenJDK 11 tutorial to state that the templates use Eclipse Temurin on Ubuntu 24.04 Noble, and replace the removed Gradle
compiledependency configuration withimplementation.Refresh the CORS post with current HTTP template names: replace Node 12 with Node 26, retain the supported
golang-httpandgolang-middlewaretemplates, and update the Python and .NET template names. Retainjava11-vert-xandruby-http.Motivation and Context
This documentation update accompanies openfaas/templates#321 and openfaas/templates#319. The Java templates are moving away from removed OpenJDK image tags, and the affected website content needs to reflect the current images, Gradle syntax, and HTTP templates.
Have you applied the editorial and style guide to your post?
Yes.
How have you tested the instructions for any tutorial steps?
Verified the image names and Gradle version against the templates change, checked the CORS template names against the upstream template repositories and template store, and ran
git diff --check.Types of changes
Checklist:
git commit -s