docs: add deploy-test-workload example proposal#115
Conversation
Add a second example proposal (deploy-test-workload.yaml) that exercises the full analysis + execution lifecycle by deploying an nginx Deployment and Service. Update install.sh and README to reference both examples. Co-authored-by: Cursor <cursoragent@cursor.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughSummary by CodeRabbitRelease Notes
WalkthroughThis PR adds a new example Proposal manifest for deploying a test workload and updates quickstart README/install to reference it, and adjusts the uninstall script to add a cluster-scoped deletion and renumber steps from 5 to 6. ChangesTest Workload Proposal Example
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
hack/quickstart/install.sh (1)
295-298:⚠️ Potential issue | 🟠 Major | ⚡ Quick winUse the matching proposal name in the approval command.
ProposalApprovalnames track the proposal name, so this command won't approve thedeploy-test-workloadexecution path. Update it to target the proposal you just applied.🛠 Proposed fix
- oc patch proposalapproval namespace-inventory -n ${NAMESPACE} \ + oc patch proposalapproval deploy-test-workload -n ${NAMESPACE} \🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@hack/quickstart/install.sh` around lines 295 - 298, The oc patch command is targeting the wrong ProposalApproval name ("namespace-inventory"); change the ProposalApproval resource name to the actual proposal you applied (e.g., "deploy-test-workload") so the approval affects the intended execution path—update the oc patch invocation that references proposalapproval and the resource name to use deploy-test-workload (keeping the rest of the flags and payload the same).
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@hack/quickstart/install.sh`:
- Around line 295-298: The oc patch command is targeting the wrong
ProposalApproval name ("namespace-inventory"); change the ProposalApproval
resource name to the actual proposal you applied (e.g., "deploy-test-workload")
so the approval affects the intended execution path—update the oc patch
invocation that references proposalapproval and the resource name to use
deploy-test-workload (keeping the rest of the flags and payload the same).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: e5e1dff1-d665-46d3-a6a4-2e1042530061
📒 Files selected for processing (3)
hack/quickstart/README.mdhack/quickstart/examples/deploy-test-workload.yamlhack/quickstart/install.sh
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
openshift/lightspeed-agentic-sandbox(manual)
…anup Add AgenticOLSConfig CR and CRD deletion, console plugin deregistration, and fix the confirmation message formatting. Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@hack/quickstart/uninstall.sh`:
- Around line 57-67: The code logs "Plugin deregistered from Console" regardless
of whether the oc patch actually succeeded; change the flow in the block that
handles PLUGIN_NAME so the patch attempt (oc patch console.operator.openshift.io
cluster ...) is executed without unconditionally swallowing failures and its
exit status is checked, and only print the success message when the patch
command returns a zero status; if patch fails, log a failure/info message and
continue to run oc delete consoleplugin "${PLUGIN_NAME}" --ignore-not-found so
the CR is removed even if the cluster spec still contains a stale reference.
Ensure you reference the same commands/objects (oc patch,
console.operator.openshift.io cluster, PLUGIN_NAME, and oc delete consoleplugin)
so the change updates the conditional logging based on the patch command result.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 46cebd53-7da4-4862-b7e9-439ed911f426
📒 Files selected for processing (1)
hack/quickstart/uninstall.sh
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
openshift/lightspeed-agentic-sandbox(manual)
Use if/then/else instead of && { } || so the success message only
prints when the patch actually succeeds.
Co-authored-by: Cursor <cursoragent@cursor.com>
onmete
force-pushed
the
feat/quickstart-examples
branch
from
4997361 to
5547375
Compare
|
@onmete: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
Summary
deploy-test-workload.yamlexample proposal that exercises the full analysis + execution lifecycle (deploys nginx Deployment + Service)namespace-inventory.yamlfor investigate-and-remediate scenariosinstall.shoutput andREADME.mdto reference both examplesTest plan
oc apply -f deploy-test-workload.yamlruns analysis and proposes deploying nginxnamespace-inventory.yamlstill works as beforeMade with Cursor