Skip to content

fix(deps): update 3 packages for core-1084 asap-jsonwebtoken - #55

Merged
philorder merged 1 commit into
mainfrom
core-1084-asap-jsonwebtoken-9
Aug 28, 2026
Merged

philorder merged 1 commit into
mainfrom
core-1084-asap-jsonwebtoken-9

Conversation

@philorder

Copy link
Copy Markdown
Contributor

update 3 packages for core-1084 asap-jsonwebtoken

@changeset-bot

changeset-bot Bot commented Aug 24, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 3c22a85

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ordermentum/asap-core Patch
@ordermentum/express-asap Patch
@ordermentum/hapi-asap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@philorder
philorder requested review from Laaaaannn and tjdavey August 25, 2026 03:24
@tjdavey

tjdavey commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

@philorder I assume the new minimum key complexity threshold for the RSA keys isn't going to be an issue in sandbox/production? Are all the keys there 2048 bits if using RSA256?

Laaaaannn
Laaaaannn previously approved these changes Aug 25, 2026
@tjdavey

tjdavey commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

@philorder I assume the new minimum key complexity threshold for the RSA keys isn't going to be an issue in sandbox/production? Are all the keys there 2048 bits if using RSA256?

I've validated the rotate_tokens script in infrastructure generates 2048 bit RSA keys.

openssl genpkey \
    -algorithm RSA \
    -out "$LOCAL_PRIVATE_KEY_PATH" \
    -pkeyopt rsa_keygen_bits:2048

https://github.com/ordermentum/infrastructure/blob/08a1ac024a7b400ec037915ace3ee2cf8e5b9506/scripts/pipeline/rotate-keys#L71-L74

tjdavey
tjdavey previously approved these changes Aug 25, 2026
@philorder
philorder dismissed stale reviews from tjdavey and Laaaaannn via 3c22a85 August 26, 2026 03:49
@philorder
philorder force-pushed the core-1084-asap-jsonwebtoken-9 branch from 49e0f15 to 3c22a85 Compare August 26, 2026 03:49
@philorder
philorder requested review from Laaaaannn and tjdavey August 26, 2026 03:50
@philorder
philorder merged commit 242db5c into main Aug 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants