Skip to content

[OPS-244] asap-javascript: refresh axios to 1.21.1 and follow-redirects to 1.16.3 - #69

Open
BCook98 wants to merge 1 commit into
mainfrom
cve/ops-244-asap-javascript-highs
Open

BCook98 wants to merge 1 commit into
mainfrom
cve/ops-244-asap-javascript-highs

Conversation

@BCook98

@BCook98 BCook98 commented Nov 20, 2026

Copy link
Copy Markdown

What

Lockfile-only refresh of axios and follow-redirects in the @ordermentum/asap monorepo.

Package From To Chain
axios 1.19.0 1.21.1 direct dep of asap-core and axios-asap (^1.19.0)
follow-redirects 1.16.0 1.16.3 axios

Why

DeepSource flags axios 1.19.0 as HIGH (12 CVEs, fixed in 1.20.0). yarn audit --level high on main reports 20 high advisories, all axios.

How

Deleted the axios@^1.19.0 and follow-redirects@^1.16.0 stanzas from yarn.lock and ran yarn install. No package.json change (the ^1.19.0 range admits the fix) and no resolutions. No changeset: published package manifests are unchanged.

Testing

Node 24.22.1 (matches CI), yarn 1.22.

  • rm -rf node_modules */*/node_modules && yarn install --frozen-lockfile: exit 0
  • yarn.lock grep: one axios entry (1.21.1), one follow-redirects entry (1.16.3); no 1.19.0 or 1.16.0
  • git diff --stat: yarn.lock only, 8 insertions, 8 deletions, only the axios and follow-redirects stanzas
  • yarn audit --level high --json: before 0 critical / 20 high / 26 moderate / 5 low; after 0 critical / 0 high / 16 moderate / 5 low. All 20 removed advisories were axios; nothing new appeared.
  • yarn build: pass
  • yarn turbo run lint --parallel: pass (no files changed)
  • yarn coverage (runs the turbo test suites): asap-core 33 passing, axios-asap 4, express-asap 4, hapi-asap 5, test-helpers 0; no failures

Dev box

Not applicable: library repo

Deferred

None.

Known no-fix

None. No high advisories remain.

🤖 Generated with Claude Code

Delete the stale axios 1.19.0 and follow-redirects 1.16.0 stanzas and
reinstall so both re-resolve within their existing ranges: axios
1.19.0 -> 1.21.1 and follow-redirects 1.16.0 -> 1.16.3. No package.json
change; the ^1.19.0 range already admits the fix.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@changeset-bot

changeset-bot Bot commented Nov 20, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 8054917

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@deepsource-io

deepsource-io Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in 4826290...8054917 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Coverage  

Code Review Summary

Analyzer Status Updated (UTC) Details
JavaScript Nov 20, 2026 12:35a.m. Review ↗
Code coverage Nov 20, 2026 12:35a.m. Review ↗
Secrets Nov 20, 2026 12:35a.m. Review ↗

Code Coverage Summary

Language Line Coverage (Overall)
Aggregate
63.7%
Javascript
63.7%

➟ Additional coverage metrics may have been reported. See full coverage report ↗


Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@BCook98
BCook98 marked this pull request as ready for review November 20, 2026 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant