Skip to content

chore(skipmaskmanager): remove skip mask files at startup if no frac#427

Open
forshev wants to merge 2 commits into
mainfrom
426-remove-skip-mask-if-no-frac
Open

chore(skipmaskmanager): remove skip mask files at startup if no frac#427
forshev wants to merge 2 commits into
mainfrom
426-remove-skip-mask-if-no-frac

Conversation

@forshev
Copy link
Copy Markdown
Collaborator

@forshev forshev commented May 20, 2026

Description

Now skip mask manager checks at startup whether existing skipmask file has corresponding fraction. If not, skip mask file is removed

Fixes #426


  • I have read and followed all requirements in CONTRIBUTING.md;
  • I used LLM/AI assistance to make this pull request;

If you have used LLM/AI assistance please provide model name and full prompt:

Model: {{model-name}}
Prompt: {{prompt}}

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 20, 2026

Codecov Report

❌ Patch coverage is 41.17647% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.58%. Comparing base (2c48a62) to head (a69a4ef).

Files with missing lines Patch % Lines
skipmaskmanager/skip_mask_manager.go 41.17% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #427      +/-   ##
==========================================
- Coverage   70.65%   70.58%   -0.07%     
==========================================
  Files         219      219              
  Lines       17009    17021      +12     
==========================================
- Hits        12017    12015       -2     
- Misses       4094     4107      +13     
- Partials      898      899       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eguguchkin eguguchkin requested review from dkharms and eguguchkin May 25, 2026 11:25
Comment thread skipmaskmanager/skip_mask_manager.go Outdated

// remove missed files
if _, ok := fracNamesSet[fracName]; !ok {
err := os.RemoveAll(path.Join(sm.dirPath, name))
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I'm kind of scared to delete RemoveAll — what if for some reason name == ""? Then the entire directory will be deleted :)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skip masks GC on startup

4 participants