Multiple test utils relays#1627
Merged
Merged
Conversation
Collaborator
Coverage Report for CI Build 27160164202Coverage increased (+0.006%) to 85.391%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
f60e635 to
b62a9f1
Compare
xstoicunicornx
approved these changes
Jun 8, 2026
xstoicunicornx
left a comment
Collaborator
There was a problem hiding this comment.
utACK b62a9f1
Updates are straightforward and sensible. As a reference implementation, payjoin-cli tests should reflect that having multiple relays available for usage is the expected behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adjusts the initialize ohttp_relay function within test utils to be able to spin up any number of relays. This came about following the addition of 36e1f6b in #1399 where every e2e test now produces a warning. In addition this PR can come in handy when we begin to flesh out the ASmap random selection to be able to better prove out its usefulness.
Written with the help of deepseek v4 flash
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.