Skip to content

Multiple test utils relays#1627

Merged
benalleng merged 3 commits into
payjoin:masterfrom
benalleng:multiple-test-utils-relays
Jun 9, 2026
Merged

Multiple test utils relays#1627
benalleng merged 3 commits into
payjoin:masterfrom
benalleng:multiple-test-utils-relays

Conversation

@benalleng

@benalleng benalleng commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

This adjusts the initialize ohttp_relay function within test utils to be able to spin up any number of relays. This came about following the addition of 36e1f6b in #1399 where every e2e test now produces a warning. In addition this PR can come in handy when we begin to flesh out the ASmap random selection to be able to better prove out its usefulness.

Written with the help of deepseek v4 flash

Pull Request Checklist

Please confirm the following before requesting review:

@benalleng benalleng requested a review from xstoicunicornx June 8, 2026 18:49
@coveralls

coveralls commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 27160164202

Coverage increased (+0.006%) to 85.391%

Details

  • Coverage increased (+0.006%) from the base build.
  • Patch coverage: 3 uncovered changes across 1 file (28 of 31 lines covered, 90.32%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
payjoin-test-utils/src/v2.rs 31 28 90.32%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 14710
Covered Lines: 12561
Line Coverage: 85.39%
Coverage Strength: 372.15 hits per line

💛 - Coveralls

@benalleng benalleng force-pushed the multiple-test-utils-relays branch from f60e635 to b62a9f1 Compare June 8, 2026 18:59

@xstoicunicornx xstoicunicornx left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK b62a9f1

Updates are straightforward and sensible. As a reference implementation, payjoin-cli tests should reflect that having multiple relays available for usage is the expected behavior.

@benalleng benalleng merged commit 98940bf into payjoin:master Jun 9, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants