Rename Monitor method

[spacebear21]

See #1656 for bikeshed details

Pull Request Checklist

Please confirm the following before requesting review:

• I have disclosed my use of
  AI
  in the body of this PR.
• I have read CONTRIBUTING.md and rebased my branch to produce hygienic commits.

[coveralls]

Coverage Report for CI Build 27838714039

Coverage decreased (-0.006%) to 85.207%

Details

• Coverage decreased (-0.006%) from the base build.
• Patch coverage: 1 uncovered change across 1 file (6 of 7 lines covered, 85.71%).
• No coverage regressions found.

Uncovered Changes

File	Changed	Covered	%
payjoin/src/core/receive/v2/mod.rs	6	5	83.33%
Total (2 files)	7	6	85.71%

Coverage Regressions

No coverage regressions found.

---

Coverage Stats

Relevant Lines:	14750
Covered Lines:	12568
Line Coverage:	85.21%
Coverage Strength:	370.21 hits per line

---

💛 - Coveralls

[benalleng]

ACK 65c2694 check_for_broadcast is clear that this relates to chain level data and not necessarily any information about whether the payjoin process was successful or it was a fallback tx; only that A transaction has been broadcast to the network.

[DanGould]

Checking for broadcast also seems like a recommendation. It's possible that a monitoring client would want to wait for a confirmation before they mark the Payjoin State machine as successful. I want to revisit this for sure before we release

[spacebear21]

It's possible that a monitoring client would want to wait for a confirmation before they mark the Payjoin State machine as successful

I thought about this but this lead back to language like "settlement", happy to change it again if you have a concrete suggestion.