Fix spelling mistakes#1665
Conversation
Coverage Report for CI Build 27916851168Coverage remained the same at 85.213%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
xstoicunicornx
left a comment
There was a problem hiding this comment.
ACK a1f7b8c
All but one of the changes exclusively update informational code (comments, md files), and the one code change is a public function renaming in the test utils that seems appropriate to me as it fixes a typo. Would like to know what the protocol is for updating a public function name like this though.
| } | ||
|
|
||
| pub fn init_bitcoind_multi_sender_single_reciever( | ||
| pub fn init_bitcoind_multi_sender_single_receiver( |
There was a problem hiding this comment.
Is there additional communication/followup that is needed to change a pub fn name?
There was a problem hiding this comment.
Nice catch 🤔
Don't necessarily need a follow-up communication... Currently believe this method isn't widely used but double checking this later
There was a problem hiding this comment.
I looked in the codebase and this method is never called anywhere
There was a problem hiding this comment.
Its ok to just make breaing changes in the test-utils for now. This lives at 0.0.1 for a reason still
|
Mind sharing the prompt / prompts that resulted in this change I think its relevant as related to #1378 |
@benalleng Sure, so every time I start a new session, I try to feed codebase patterns, so it can search faster later. Still, it seems the past few hours the agent has been trying to do more, so while I had the agent in the background executing on this prompt: What I think happened, twice now in the last 16 hours, since I got a codex update, the agent has been making its own goals in the background. The worst case is that it just runs out of tokens attempting some self-defined goals, but I can see it being more useful... this is probably a glitch in the goal system that keeps self-prompting until goal status is achieved or blocked, for example, if it's pursuing a goal and you tell it to stop without using /goal clear, it enters a self prompt standby loop until you actually clear the goal or say "continue". Non-deterministic at the core, though |
While I was scanning the repo, my AI went rogue and started fixing unrelated issues. This PR took a few of those and only contains:
Figured not to waste the tokens
Disclosure: co-authored by Codex