Skip to content

Fix spelling mistakes#1665

Merged
benalleng merged 2 commits into
payjoin:masterfrom
chavic:spelling-fixes
Jun 22, 2026
Merged

Fix spelling mistakes#1665
benalleng merged 2 commits into
payjoin:masterfrom
chavic:spelling-fixes

Conversation

@chavic

@chavic chavic commented Jun 21, 2026

Copy link
Copy Markdown
Collaborator

While I was scanning the repo, my AI went rogue and started fixing unrelated issues. This PR took a few of those and only contains:

  • Fix spelling and typo issues in docs, changelogs, comments, and release checklist text.
  • Correct the misspelled test utility helper name.

Figured not to waste the tokens

Disclosure: co-authored by Codex

@chavic chavic requested a review from xstoicunicornx June 21, 2026 20:44
@coveralls

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 27916851168

Coverage remained the same at 85.213%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: 1 uncovered change across 1 file (1 of 2 lines covered, 50.0%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
payjoin-test-utils/src/lib.rs 1 0 0.0%
Total (2 files) 2 1 50.0%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 14749
Covered Lines: 12568
Line Coverage: 85.21%
Coverage Strength: 370.21 hits per line

💛 - Coveralls

@chavic chavic marked this pull request as ready for review June 21, 2026 20:46

@xstoicunicornx xstoicunicornx left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a1f7b8c

All but one of the changes exclusively update informational code (comments, md files), and the one code change is a public function renaming in the test utils that seems appropriate to me as it fixes a typo. Would like to know what the protocol is for updating a public function name like this though.

}

pub fn init_bitcoind_multi_sender_single_reciever(
pub fn init_bitcoind_multi_sender_single_receiver(

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there additional communication/followup that is needed to change a pub fn name?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 🤔

Don't necessarily need a follow-up communication... Currently believe this method isn't widely used but double checking this later

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked in the codebase and this method is never called anywhere

@benalleng benalleng Jun 22, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its ok to just make breaing changes in the test-utils for now. This lives at 0.0.1 for a reason still

@caarloshenriq caarloshenriq left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a1f7b8c

@benalleng

Copy link
Copy Markdown
Collaborator

Mind sharing the prompt / prompts that resulted in this change I think its relevant as related to #1378

@benalleng benalleng left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a1f7b8c

@benalleng benalleng merged commit dd61077 into payjoin:master Jun 22, 2026
24 checks passed
@chavic

chavic commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator Author

Mind sharing the prompt / prompts that resulted in this change I think its relevant as related to #1378

@benalleng Sure, so every time I start a new session, I try to feed codebase patterns, so it can search faster later. Still, it seems the past few hours the agent has been trying to do more, so while I had the agent in the background executing on this prompt: your goal is to master the repository and all the concepts and architectural decisions it's based around, I noticed in a different session that 90% of my 5hr limit was used up, turns out the first agent went around fixing things while it was following the code flow. #1666 was one of these changes, too.

What I think happened, twice now in the last 16 hours, since I got a codex update, the agent has been making its own goals in the background. The worst case is that it just runs out of tokens attempting some self-defined goals, but I can see it being more useful... this is probably a glitch in the goal system that keeps self-prompting until goal status is achieved or blocked, for example, if it's pursuing a goal and you tell it to stop without using /goal clear, it enters a self prompt standby loop until you actually clear the goal or say "continue". Non-deterministic at the core, though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants