Skip to content

Add directory fallback behavior#1695

Open
benalleng wants to merge 1 commit into
payjoin:masterfrom
benalleng:fallback-directories
Open

Add directory fallback behavior#1695
benalleng wants to merge 1 commit into
payjoin:masterfrom
benalleng:fallback-directories

Conversation

@benalleng

Copy link
Copy Markdown
Collaborator

This adds the ability for a backup directory to be chosen by the receiver incase of a failure on the ohttp key fetch.

As well now that there is Relay and directory management the Struct is better suited as MailroomManager.

Supersedes #1294

relates to the directory fallbacks in #1007

Pull Request Checklist

Please confirm the following before requesting review:

This adds the ability for a backup directory to be chosen by the
receiver incase of a failure on the ohttp key fetch.

As well now that there is Relay and directory management the Struct is
better suited as MailroomManager.

Co-authored-by: Oladapo Oyindamola <111582215+0xZaddyy@users.noreply.github.com>
@benalleng benalleng marked this pull request as ready for review June 29, 2026 16:37
@coveralls

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 28387717154

Coverage decreased (-0.002%) to 85.515%

Details

  • Coverage decreased (-0.002%) from the base build.
  • Patch coverage: 16 uncovered changes across 2 files (36 of 52 lines covered, 69.23%).
  • 1 coverage regression across 1 file.

Uncovered Changes

File Changed Covered %
payjoin-cli/src/app/v2/ohttp.rs 37 22 59.46%
payjoin-cli/src/app/v2/mod.rs 2 1 50.0%
Total (3 files) 52 36 69.23%

Coverage Regressions

1 previously-covered line in 1 file lost coverage.

File Lines Losing Coverage Coverage
payjoin-cli/src/app/config.rs 1 81.01%

Coverage Stats

Coverage Status
Relevant Lines: 15161
Covered Lines: 12965
Line Coverage: 85.52%
Coverage Strength: 361.12 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants