Skip to content

fix: enable collection-taint regression cases after upstream cpg#2781 #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ph0smet merged 1 commit into from
Jun 14, 2026
Merged

fix: enable collection-taint regression cases after upstream cpg#2781 #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions src/test/kotlin/io/github/blindhacker99/codereason/DataflowIntegrationTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,15 @@ import de.fraunhofer.aisec.cpg.passes.ProgramDependenceGraphPass
import java.io.File
import kotlin.test.Test
import kotlin.test.assertTrue
import org.junit.jupiter.api.Disabled

/**
* Regression suite for forward DFG taint propagation across four shapes:
* direct assignment, array element write, List.add/get, Map.put/get.
*
* Cases 3 and 4 are gated on Fraunhofer-AISEC/cpg#2748 — function summaries with
* `to: base` apply at the function-decl level for inferred JDK methods but the
* call-site reverse propagation edge is missing, so taint does not flow back to
* the variable through `list.add(taint); list.get(i)` patterns.
* Cases 3 and 4 cover function summaries with `to: base` on inferred JDK methods.
* These were gated on Fraunhofer-AISEC/cpg#2748 (the call-site reverse propagation
* edge was missing); the upstream fix landed in #2781 (commit 562a692, 2026-06-05),
* so taint now flows back to the variable through `list.add(taint); list.get(i)`.
*/
class DataflowIntegrationTest {

Expand Down Expand Up @@ -94,7 +93,6 @@ class DataflowIntegrationTest {
}

@Test
@Disabled("Pending Fraunhofer-AISEC/cpg#2748 — function summary `to: base` not propagating to call site for inferred Java library methods")
fun `case 3 List add then get propagates taint`() {
val result = analyzeFile("fixtures/java/dataflow/CollectionTaint.java")
val reachable = reachableViaDFG(findSourceCallAtLine(result, 30))
Expand All @@ -103,7 +101,6 @@ class DataflowIntegrationTest {
}

@Test
@Disabled("Pending Fraunhofer-AISEC/cpg#2748 — function summary `to: base` not propagating to call site for inferred Java library methods")
fun `case 4 Map put then get propagates taint`() {
val result = analyzeFile("fixtures/java/dataflow/CollectionTaint.java")
val reachable = reachableViaDFG(findSourceCallAtLine(result, 36))
Expand Down
Loading