Repository navigation
Conversation
✅ Deploy Preview for pihole-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
I'm not sure if these options are available on the new system, but do we need them?
The new search window is a little different, but it also shows all results in real time while you type the search string, like mkdocs search. Not sure if the suggestions are needed. |
|
The whole search was completely re-implemented. We probably don't need Note: I removed |
Not sure if we really need this.
Can you provide a screenshot using the "classic" theme? |
It depends if they implement warning about files not included in the navigation. Tracking here: zensical/zensical#124
This is 1:1 the current Materials for MkDocs theme we use. So all screenshots are at https://docs.pi-hole.net/ |
i vote modern. (though i'm sure my vote doesnt count much😂😂) |
204e8b4 to
30ae486
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. |
Signed-off-by: yubiuser <github@yubiuser.dev>
Signed-off-by: yubiuser <github@yubiuser.dev>
Signed-off-by: yubiuser <github@yubiuser.dev>
Signed-off-by: yubiuser <github@yubiuser.dev>
Signed-off-by: yubiuser <github@yubiuser.dev>
Signed-off-by: yubiuser <github@yubiuser.dev>
Signed-off-by: yubiuser <github@yubiuser.dev>
Signed-off-by: yubiuser <github@yubiuser.dev>
Signed-off-by: yubiuser <github@yubiuser.dev>
Signed-off-by: yubiuser <github@yubiuser.dev>
Signed-off-by: yubiuser <github@yubiuser.dev>
Signed-off-by: yubiuser <github@yubiuser.dev>
…stalled as compatibility layer on musl based Alpine for the glic binary Signed-off-by: yubiuser <github@yubiuser.dev>
Signed-off-by: yubiuser <github@yubiuser.dev>
Signed-off-by: yubiuser <github@yubiuser.dev>
Signed-off-by: yubiuser <github@yubiuser.dev>
Signed-off-by: yubiuser <github@yubiuser.dev>
Signed-off-by: yubiuser <github@yubiuser.dev>
Signed-off-by: yubiuser <github@yubiuser.dev>
Signed-off-by: yubiuser <github@yubiuser.dev>
Signed-off-by: yubiuser <github@yubiuser.dev>
Signed-off-by: yubiuser <github@yubiuser.dev>
- remove some unnecessary changes; - use some color variables for better consistency; - adjust CSS selector to actually apply link color in dark mode; - adjust some colors to increase contrast and readability. Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
Signed-off-by: yubiuser <github@yubiuser.dev>
Details: - Add custom color for both light and dark modes (medium-dark blue); - use the custom color as header background and change the text to white, keeping a very good contrast; - use a lighter color for link hover effect (dark mode); - add a white circle behind the Pi-hole logo on the header. Without this background the logo looks very ugly in dark mode (or on top of any dark color). - use the custom color for the active link text (light mode), increasing the contrast ratio from 3.75:1 to 9.02:1. - use the custom color as active menu item background (with white text) - contrast ratio = 10.74:1. Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
Signed-off-by: yubiuser <github@yubiuser.dev>
Signed-off-by: yubiuser <github@yubiuser.dev>
Signed-off-by: yubiuser <github@yubiuser.dev>
|
Conflicts have been resolved. |
What does this PR aim to accomplish?:
mkdocs-materialis in maintenance mode and their creators build a new site generation tool calledzensical(here). It offers a back-wards compatibility tomkdocs-materialso the transition is quite smooth.This is work in progress
Internal
markdown_includewithsnippetsas the former did not work well with zensical (adapts Add deprecation notice to OpenVPN pages [v6] #1029)zensical.tomlclassicvsmodern)External
git-revision-date-localized-pluginis still needed, Trackersearch.suggestandsearch.share--strictis missing, affecting link validation (Fixed with https://github.com/zensical/zensical/releases/tag/v0.0.38)not_in_nav, Tracker(Fixed in https://github.com/zensical/zensical/releases/tag/v0.0.70)validation.nav.not_found, TrackerBy submitting this pull request, I confirm the following:
git rebase)