Repository navigation
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Adam Warner <github@promofaux.dev>
1 task done
✅ Deploy Preview for pihole-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
rdwebdesign
approved these changes
Oct 31, 2026
rdwebdesign
left a comment
Member
There was a problem hiding this comment.
Note:
Merge only after the Core PR
darkexplosiveqwx
approved these changes
Oct 31, 2026
darkexplosiveqwx
left a comment
Contributor
There was a problem hiding this comment.
Merge only after pi-hole/pi-hole#6749 is included in a tagged release.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR aim to accomplish?:
Supports pi-hole/pi-hole#6749.
pihole flushis documented as also rotating the log daily whenlogrotateis installed. Once the nightly cron job is removed from core, that is no longer true, and the page should say what actually rotates the logs.How does this PR accomplish the above?:
docs/main/pihole-command.md: replace "The command also serves to rotate the log daily, if thelogrotateapplication is installed." with: "Pi-hole's logs are rotated separately by the system's scheduledlogrotaterun, using the configuration in/etc/logrotate.d/pihole:pihole.logdaily,FTL.logandwebserver.logweekly."This should only merge together with or after pi-hole/pi-hole#6749.
Link documentation PRs if any are needed to support this PR:
N/A (this is the documentation PR)
By submitting this pull request, I confirm the following:
🤖 Generated with Claude Code