Skip to content

pihole flush: logs are rotated by the system's logrotate - #1448

Open
PromoFaux wants to merge 1 commit into
masterfrom
logrotate-docs
Open

PromoFaux wants to merge 1 commit into
masterfrom
logrotate-docs

Conversation

@PromoFaux

Copy link
Copy Markdown
Member

What does this PR aim to accomplish?:

Supports pi-hole/pi-hole#6749. pihole flush is documented as also rotating the log daily when logrotate is installed. Once the nightly cron job is removed from core, that is no longer true, and the page should say what actually rotates the logs.

How does this PR accomplish the above?:

  • docs/main/pihole-command.md: replace "The command also serves to rotate the log daily, if the logrotate application is installed." with: "Pi-hole's logs are rotated separately by the system's scheduled logrotate run, using the configuration in /etc/logrotate.d/pihole: pihole.log daily, FTL.log and webserver.log weekly."

This should only merge together with or after pi-hole/pi-hole#6749.

Link documentation PRs if any are needed to support this PR:

N/A (this is the documentation PR)


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits.
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.
  • I have read the above and my PR is ready for review.

🤖 Generated with Claude Code

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Adam Warner <github@promofaux.dev>
@netlify

netlify Bot commented Oct 30, 2026

Copy link
Copy Markdown

✅ Deploy Preview for pihole-docs ready!

Name Link
🔨 Latest commit 6afe2cb
🔍 Latest deploy log https://app.netlify.com/projects/pihole-docs/deploys/6ae52c74a86982599ab57a81
😎 Deploy Preview https://deploy-preview-1448--pihole-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@rdwebdesign rdwebdesign left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note:
Merge only after the Core PR

@darkexplosiveqwx darkexplosiveqwx left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge only after pi-hole/pi-hole#6749 is included in a tagged release.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants