fix(deps): bump rendezvous to fix accept rate-limiter data race#250
Merged
Conversation
rendezvous v0.2.4 had a data race in globalRateBucket.allow() (the process-wide accept rate limiter mutated tokens/lastFill without a lock, called concurrently from every connection handler). This surfaced as the Architecture gates job's TestConcurrentDialEncryptDecrypt failing under -race. Bump to the fixed rendezvous (mutex-guarded; pilot-protocol/rendezvous#73), which pulls beacon v0.2.6 transitively. Verified: go test -race TestConcurrentDialEncryptDecrypt ./tests passes (104s, no race).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
Architecture gatesCI failure (TestConcurrentDialEncryptDecryptunder
-race), which has been red onmainsince June 9.The failure is a data race in the
rendezvousdependency, not in thisrepo:
globalRateBucket.allow()(the process-wide accept rate limiter)performed an unsynchronized read-modify-write on
tokens/lastFillwhilebeing called concurrently from every
Acceptorconnection handler.This bumps
rendezvousv0.2.4 → the mutex-guarded fix(pilot-protocol/rendezvous#73), which pulls
beaconv0.2.6 transitively.Testing
go test -race -count=1 -run TestConcurrentDialEncryptDecrypt ./testsnow passes (104s, no DATA RACE) — previously failed with the race.
go build ./...clean.Notes
tagged
v0.2.5once fix(accept): guard globalRateBucket.allow with a mutex (data race) rendezvous#73 merges + releases.