fix(telemetry): default daemon to production endpoint; emit app_usage on pilotctl call#293
Open
TeoSlayer wants to merge 2 commits into
Open
fix(telemetry): default daemon to production endpoint; emit app_usage on pilotctl call#293TeoSlayer wants to merge 2 commits into
TeoSlayer wants to merge 2 commits into
Conversation
… on call - cmd/daemon/main.go: default -telemetry-url to telemetry.DefaultEndpoint when PILOT_TELEMETRY_URL is unset. Previously the daemon silently dropped all telemetry because the flag defaulted to "" (hard no-op). - cmd/pilotctl/appstore.go: emit app_usage event after a successful `pilotctl appstore call`. Previously this event was only reachable through the daemon supervisor path, not the direct IPC call path. Both emissions are consent-gated (telemetry flag, default on) and best-effort. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Alexgodoroja
approved these changes
Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two telemetry gaps closed:
1. Daemon never sent events by default
The
-telemetry-urlflag defaulted to""(hard no-op) unlessPILOT_TELEMETRY_URLwas set explicitly. Thetelemetry.DefaultEndpointconstant was only printed in help text, never used. Allapp_usageevents from the daemon supervisor were silently dropped.2.
pilotctl appstore callnever emittedapp_usageThe
app_usagekind was only reachable through the daemon's internal supervisor path, not the direct IPC call path that users actually invoke. Everypilotctl appstore call <id> <method>went untracked.Fix
cmd/daemon/main.go: fall back totelemetry.DefaultEndpointwhenPILOT_TELEMETRY_URLis unset (same pattern pilotctl already uses)cmd/pilotctl/appstore.go: emitapp_usageafter a successful call, consent-gated + best-effortTest
Both paths can be verified with
PILOT_TELEMETRY_URL=https://telemetry.pilotprotocol.networkand checking BigQuery for incoming events.