Repository navigation
Replace kamon-play with a Play 3 only module supporting Scala 2.13 and 3 - #3
Merged
Merged
Conversation
kamon-play is built against Play 2.8 and depends on the Akka modules, so it can't be built for Scala 3. kamon-play3 supports only Play 3 (Pekko) and is cross-built for Scala 2.13 and 3. Advices use the class plus @static pattern because Scala 3 static forwarders drop parameter annotations. Fixes kamon-io#1418 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pjfanning
force-pushed
the
kamon-play3
branch
from
October 10, 2026 20:48
ce93c65 to
f924661
Compare
…play This fork only supports Play 3 (Pekko), so the module takes over the kamon-play name. The old Akka-based module was not built by this fork. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pjfanning
changed the title
Play 3 requires Java 11+ (its jars are class file version 55), so on Java 8 the kamon-play tests fail with UnsupportedClassVersionError and the job hangs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings over kamon-io#1433: a Play 3 (Pekko) only module cross-built for Scala 2.13 and 3. In this fork it takes over the
kamon-playname, and the old Akka-basedkamon-playmodule (which this fork never built) is deleted.build.sbtconflict resolved for this fork's Pekko-only build. Rebased ontomain; the.disablePlugins(AssemblyPlugin)line is dropped since Upgrade sbt to 1.13.0 and the sbt plugins #1 removed sbt-assembly.instrumentation/kamon-play3toinstrumentation/kamon-play, deletes the old Akka-based module, and updatesbuild.sbt, the test config paths, thereference.confheader and the README.kamon-playdepends onkamon-pekkoandkamon-pekko-httpfrom this build, and onio.kamon:kamon-testkitfor tests. It's ininstrumentationProjects, so CI tests it and it's published ascom.github.pjfanning:kamon-play_2.13/kamon-play_3.kamon.instrumentation.play).The upstream follow-up commit only added comments about the bundles, which this fork doesn't build, so it isn't included.
Tested locally on Java 17:
"+scalafmtCheckAll;scalafmtSbtCheck"passes,"+kamon-play/test"passes 18/18 on Scala 2.13.13 and 3.3.5, and"+kamon-play/publishLocal"publisheskamon-play_2.13andkamon-play_3.🤖 Generated with Claude Code