Repository navigation
Refs GRE-402: admit list_example_builds and get_print_stats resources - #1241
Conversation
Declare reviewed resource unions for two Node-owned plan summary reads, traced through real dispatch under trusted and isolated policies: - tool.list_example_builds: the tool.list_plans union plus kit-catalog. - tool.get_print_stats: the tool.list_plans union, the accepted-progress tables and the new print_jobs table. list_plans and both new entries share one plan_headers set in Rust. Reviewed 61 -> 63, unresolved 381 -> 379. The scope doc also corrects its stale 443/382 totals to the pinned 442/379. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
seat exhausted: opencode/glm-5.3-flash-free (head aea13b4) |
|
seat exhausted: opencode/deepseek-v4.1-flash-free (head aea13b4) |
|
owner-lock: VM134 scorer claude-sonnet-5-5 (halo seat 429) |
|
score 9/10 claude-sonnet-5-5 head aea13b4 I read the diff and checked the declared resource sets against Findings:
What holds up:
|
|
owner-lock: VM134 scorer pi/halo/qwen38-flash |
|
VM134: rust (windows) failed with 'self-hosted runner lost communication' (infra, unrelated to the diff). One rerun of the failed jobs on head aea13b4: run 40384087782 attempt 2. |
|
owner-lock: VM134 author claude-opus-5-5 (fix round 1: merge origin/main; previous lock expired at 20:41Z) |
Resolve the ticket_t_7 partition conflict: main removed six unresolved operations (381 -> 375) and this branch admits two (61 -> 63 reviewed), so the merged partition is 63 reviewed and 373 unresolved. Update the GRE-402 scope totals to match. Refs GRE-402 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Fix round 1 (merge only): merged origin/main into the branch to clear the merge conflict. The new head is abe152c. The only conflict was the ticket_t_7 partition count, now 63 reviewed and 373 unresolved. Local gateway tests, clippy, the vitest file and typecheck are green; Evidence is updated. The 9/10 score on aea13b4 no longer counts. Rescore needed on abe152c by a seat other than claude-opus-5-5. owner-lock released |
# Conflicts: # rust/crates/pp-gateway/tests/ticket_t_7_operation_resources.rs
ScoresPR head:
Defectsmerge none found
Note 🤖 gemini-3.8-flash-high responding on behalf of poitee Score: 9/10 from gemini-3.8-flash-high on head 87351fb |
Summary
Next GRE-402 (T-7-ownership) slice after #1231. It admits reviewed resource unions for two Node-owned assistant reads that summarize plans. Both are traced through real dispatch under the trusted and isolated policies:
tool.list_example_builds: thetool.list_plansunion pluskit-catalog. WithuseOtherBuildsAsExamplesoff it returns before any read. Otherwise it loads the kit catalog, reads theassistant_feedbacksetting to rank plans, and lists tenant plan headers (the samelistProfileHeadersreads aslist_plans). For each of up to five other plans, it repeats the ownership check, reads layers and their project rows, and reads thekit_manifest_<id>androle_filaments_<id>settings. Under the isolated policy it probes layer workspaces.tool.get_print_stats: thetool.list_plansunion, the accepted-progress tables (plan_revisions,plan_revision_parts,plan_revision_required_unit_sets,plan_revision_required_units,print_progress,required_units) and a newprint_jobstable. WithPP_DESKTOP_REBUILD, it reads the farm toggle inapp_settingsfirst; a disabled or invalid toggle returns before any other read, as does an invalidhourswindow. It does not contact printer hosts or Spoolman.tool.get_farm_statusstays unresolved.Rust adds
TableId::PrintJobs.list_plansand both new entries share oneplan_headersset. The rollback-format helper in the Rust test now takes the full format list, so the two interaction-graph tests pass their formats explicitly.Reviewed goes from 61 to 63, unresolved from 381 to 379 (373 after merging main, which removed six unresolved operations in #1240).
GRE-402-remaining-scope.mdis updated. It also corrects stale totals: it said 443 resolved and 382 unresolved, but the Rust test pins 442 and 381.This PR changes no runtime behavior. It adds declarations and the tests that check them. Nothing enforces them yet, and no operation moves to Rust.
Evidence
Fix round 1: merge origin/main (head
abe152c6)Merged
origin/mainatce36a1cfwith no rebase or force-push. One conflict, in the partition asserts ofrust/crates/pp-gateway/tests/ticket_t_7_operation_resources.rs. Main moved unresolved from 381 to 375, and this branch moved reviewed from 61 to 63. The merged values are 63 reviewed and 373 unresolved. The totals inGRE-402-remaining-scope.mdchanged to match: 436 resolved, 373 unresolved.ownership-manifest.jsonmerged cleanly. Ran withCARGO_TARGET_DIR=/persist/targets/GRE-402.cargo check -p pp-gateway --tests: ok.cargo test -p pp-gateway: every target passed (103 inticket_t_7_operation_resources, 30 inticket_t_3_drain_cutover), 0 failed.cargo clippy --locked -p pp-gateway --all-targets -- -D warnings: clean.cargo fmt --check -p pp-gateway: clean.npx vitest run src/assistant/operation-resources.test.ts(web/apps/server): 124 passed.npm run typecheck(web root): exit 0.Original slice (head
aea13b458)Head
aea13b458, branched from main74fc33327. Ran withumask 022andCARGO_TARGET_DIR=/persist/targets/GRE-402. pp-compat used a freshly generatedrust/bundle-manifest.json.npx vitest run src/assistant/operation-resources.test.ts -t "list_example_builds|get_print_stats|example builds and print stats"failed 4 of 5 withMissing tool.list_example_builds declaration/Missing tool.get_print_stats declaration. Every trace assertion before the declaration check had already passed. After adding the declarations: 5 passed.npx vitest run src/assistant/operation-resources.test.ts(web/apps/server): 124 passed. New tests:exclude_plan_idexclusion, kit selection and role filament summaries, tenant isolation, empty result. Every SQL statement is rejected under the other tenant's classifier.app_settingsread), tenant isolation.print_jobs,source_docs, writes and undeclared files.npx vitest run src/assistant(web/apps/server): 27 files, 397 passed.cargo nextest run --locked -p pp-gateway --no-tests=fail: 231 passed, 0 failed. This includesticket_t_7_operation_resourceswith the newlist_example_buildsandget_print_statstests and the 63/379 partition.cargo clippy --locked -p pp-gateway --all-targets -- -D warnings: clean.cargo fmt --check -p pp-gateway: clean.python3 rust/scripts/check-ast-grep.py: counts match the baseline.npm run typecheck(web root): exit 0.npx eslint src/assistant/operation-resources.test.ts: clean.npm run test:ci: 4692 passed, 3 failed, 1 skipped (344 files). All three failures were timeouts under full parallel load (15 s and 30 s), inownership-migration,accepted-plan-progress-summary(the 10,001-unit PostgreSQL page test) andsource-sync-admission.runtime(stdio MCP refusal). Refs GRE-402: admit get_interaction_graph and check_stack_compatibility resources #1231 recorded the same timeouts. This diff touches none of those files. Rerun serially (--maxWorkers=1 --no-file-parallelism), the three files passed 151/151.Merge Danger
Two-way door. The diff adds only manifest declarations, one table enum variant, two admission entries, and tests. No runtime path calls the resource index yet. Blast radius: bundled manifest admission in pp-gateway. A wrong declaration fails admission or tests, and cannot touch user data.
Refs GRE-402
🤖 Generated with Claude Code
Author-Vendor: anthropic
(Author per owner-lock comment: VM134 author claude-opus-5-5.)