Repository navigation
Fixes GRE-800: prove job socket reconnect and shutdown - #1256
Merged
Merged
Conversation
A socket that misses the claim and sixteen progress updates closes 1011. The next upgrade returns the current public snapshot at progress 16. Owner shutdown closes every live socket with that same 1011, and a later upgrade is HTTP 500.
Seventeen publishes before the pump admits another frame close the socket with 1011. The current_thread test forces that order. The helper comment now says claim plus progress 1 through 15 fill the mailbox, and progress 16 lags it. Sol round 1 on 1816fd8. Fuller job-row checks and read timeouts stay out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes GRE-800
Summary
A job socket closes 1011 when 17 snapshots publish before its pump admits another frame. The next upgrade returns the current public snapshot at progress 16, with no
updated_at. Owner shutdown closes every live socket with that same 1011, and a later upgrade is HTTP 500.The test uses a current_thread runtime so those publishes finish before the pump runs. Production
jobs.rsis unchanged.Definition of done
See the definition of done.
Evidence
Feature-on
cargo test -p pp-api --locked --manifest-path rust/Cargo.toml --features desktop_rebuild --test jobs_http -- --test-threads=2withCARGO_TARGET_DIR=/persist/targets/gre-800-job-wsandCARGO_BUILD_JOBS=2: 18 passed, 0 failed.Feature-off filters
job_ws_reconnect_returns_authoritative_snapshotandjobs_router_shutdown_closes_subscriptions: 1 passed each. Those are the 404 stubs.cargo clippy -p pp-api --locked --manifest-path rust/Cargo.toml --features desktop_rebuild --all-targets -- -D warnings: clean.cargo clippy -p pp-api --locked --manifest-path rust/Cargo.toml --all-targets -- -D warnings: clean.cf15bc5cchangesdocs/gre-800-jobs-http.mdand test comments only. The commands above ran on1816fd83.Exemption
Exemption: none
Council review
Rounds: 1
All three approved
cf15bc5ce5c3eb43c72429e5a68ac2997164196a. Nits were declined so this head stays. They cover admit-versus-pump wording, spelling out 500 versus 503, a fuller job-row compare, foldingclose_ownerintoshutdown, asserting initial progress 0, a sub-threshold publish, a read timeout, and a shared slot constant.Reviewed with sol-loop: 1 round with Claude Opus 5.5 on xhigh. Sol verdict: changes on the doc wording. That wording is corrected in
cf15bc5c. A fuller job-row snapshot and read timeouts were declined.Created with Grok 4.7 in T3 Code.