Skip to content

fix: preserve own worker launch option descriptors - #3342

Merged
jerome-benoit merged 1 commit into
poolifier:masterfrom
jerome-benoit:fix/preserve-worker-option-descriptors
Oct 15, 2026
Merged

jerome-benoit merged 1 commit into
poolifier:masterfrom
jerome-benoit:fix/preserve-worker-option-descriptors

Conversation

@jerome-benoit

Copy link
Copy Markdown
Contributor

PR Checklist

  • Please add a description of your changes.
  • Please ensure title follows conventional commits.
  • We need your changes to come with unit tests in order to keep this project in quality and easy to maintain.
  • If your changes contain any new feature please be sure to document it.
  • Please add a link to the open issue or task that this pull request will resolve.

Does this PR introduce a breaking change?

  • Yes
  • No

Description

  • preserve every own WorkerOptions property, including non-enumerable descriptors, while excluding inherited values
  • apply SHARE_ENV only when no explicit own env option exists
  • enforce own-property checks at the pool worker launch boundaries
  • align the shared option-cloning semantics with poolifier-web-worker

Related: poolifier/poolifier-web-worker#185

Validation

  • pnpm lint
  • mise exec -- pnpm test:coverage: 21 files passed; 320 tests passed; 5 skipped
  • real FixedThreadPool smoke: explicit non-enumerable env and execArgv reached the worker
  • poolifier-web-worker counterpart: 2 files passed; 16 steps passed
  • normalized TypeScript AST comparison: shared clone helper equivalent; all 7 shared runtime keys matched
  • independent security, harmonization, and maintainability reviews: approved

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-14T23:57:22.616123Z e304134 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jerome-benoit
jerome-benoit merged commit 216e95b into poolifier:master Oct 15, 2026
20 of 21 checks passed
@jerome-benoit
jerome-benoit deleted the fix/preserve-worker-option-descriptors branch October 15, 2026 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant