Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 7 additions & 27 deletions bun.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion web/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,9 @@
"@codemirror/view": "^6.43.15",
"@lezer/highlight": "^1.2.5",
"@lobehub/icons-static-svg": "^1.98.0",
"@pierre/diffs": "^1.5.1",
"@pierre/diffs": "^1.6.1",
"@pierre/highlights": "0.2.0",
"@pierre/theme": "2.0.0",
"@radix-ui/react-popover": "^1.3.1",
"@shikijs/core": "^4.5.0",
"@shikijs/langs": "^4.5.0",
Expand Down
5 changes: 5 additions & 0 deletions web/src/diffHighlightsThemes.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
// Keep the optional Highlights backend aligned with the diff viewer's themes.
export const themes = {
"pierre-dark": () => import("@pierre/highlights/themes/pierre-dark"),
"pierre-light": () => import("@pierre/highlights/themes/pierre-light"),
};
43 changes: 43 additions & 0 deletions web/src/diffThemes.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
import { expect, test } from "bun:test";
import { DEFAULT_THEMES } from "@pierre/diffs";
import { themes as highlightsThemes } from "./diffHighlightsThemes";
import { themes } from "./diffThemes";
import config from "../vite.config";

test("diff bundles use curated language and theme catalogs", () => {
const aliases = config.resolve?.alias;
expect(Array.isArray(aliases)).toBe(true);
if (!Array.isArray(aliases))
throw new Error("Expected explicit Vite aliases");
const replacement = (specifier: string) =>
aliases.find(({ find }) =>
typeof find === "string" ? find === specifier : find.test(specifier),
)?.replacement;
expect(replacement("shiki")).toEndWith("/src/shiki.ts");
expect(replacement("shiki/langs")).toBe(replacement("shiki"));
expect(replacement("shiki/core")).toBeUndefined();
expect(replacement("shiki/wasm")).toBeUndefined();
expect(replacement("@pierre/theming/themes")).toEndWith("/src/diffThemes.ts");
expect(replacement("@pierre/highlights/themes/loader")).toEndWith(
"/src/diffHighlightsThemes.ts",
);
});

test("curated diff catalogs load both default theme formats", async () => {
expect(Object.keys(highlightsThemes).sort()).toEqual(
Object.values(DEFAULT_THEMES).sort(),
);
for (const name of Object.values(DEFAULT_THEMES)) {
const descriptor = themes.getTheme(name);
expect(descriptor).toBeDefined();
const textmate = (await descriptor!.load()).default;
expect(textmate.name).toBe(name);
const zed = (
await highlightsThemes[name as keyof typeof highlightsThemes]()
).default;
expect(zed.appearance).toBe(textmate.type);
expect(zed.style).toBeDefined();
}
expect(themes.getTheme("toString")).toBeUndefined();
expect(themes.getTheme("github-dark")).toBeUndefined();
});
12 changes: 12 additions & 0 deletions web/src/diffThemes.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
// Keep the catalog limited to the two themes exposed by the diff viewer.
const loaders = {
"pierre-dark": () => import("@pierre/theme/pierre-dark"),
"pierre-light": () => import("@pierre/theme/pierre-light"),
};

export const themes = {
getTheme(name: string) {
if (!Object.prototype.hasOwnProperty.call(loaders, name)) return undefined;
return { load: loaders[name as keyof typeof loaders] };
},
};
15 changes: 14 additions & 1 deletion web/vite.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,21 @@ export default defineConfig({
plugins: [react()],
resolve: {
alias: [
// Diff viewers expose only Pierre light/dark, not the full theme catalogs.
{
find: /^shiki$/,
find: /^@pierre\/theming\/themes$/,
replacement: fileURLToPath(
new URL("./src/diffThemes.ts", import.meta.url),
),
},
{
find: /^@pierre\/highlights\/themes\/loader$/,
replacement: fileURLToPath(
new URL("./src/diffHighlightsThemes.ts", import.meta.url),
),
},
{
find: /^shiki(?:\/langs)?$/,
replacement: fileURLToPath(new URL("./src/shiki.ts", import.meta.url)),
},
],
Expand Down
Loading