Repository navigation
Conversation
This was referenced Nov 19, 2026
belisoful
force-pushed
the
tdbcache-firebird
branch
2 times, most recently
from
November 19, 2026 20:19
dfa1acf to
89d7c6d
Compare
belisoful
force-pushed
the
tdbcache-firebird
branch
from
November 20, 2026 02:13
89d7c6d to
821e6b6
Compare
belisoful
marked this pull request as ready for review
November 21, 2026 01:47
belisoful
force-pushed
the
tdbcache-firebird
branch
from
November 21, 2026 01:53
81ef0a7 to
256d352
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1497.
TDbCacheon Firebird, the open finding from #1589.VALUEis a reserved word in Firebird, soTDbCachecould not create its table there:CREATE TABLE ... (itemkey CHAR(128) NOT NULL PRIMARY KEY, value BLOB, expire INTEGER)failed with SQL error -104, "Token unknown".Fix:
getValueColumn()returns the value column as SQL:"VALUE"on Firebird, the name Firebird gives an unquotedvalue, andvalueelsewhere. The table creation, the read, the insert, and the upsert use it, so other drivers' SQL is unchanged.set()on Firebird upserts withUPDATE OR INSERT ... MATCHING (itemkey)(getUpsertSql()); it deleted and inserted in a transaction.Tests:
TDbCacheFirebirdTestrunsTDbCacheDriverTestTraiton the Firebird server of thePrado Data (Firebird)job.TDbCacheTest::testFirebirdQuotesTheValueColumnchecks the Firebird SQL in the unit suite.The full unit suite passes with
XDEBUG_MODE=off, the new unit test passes on PHP 8.2 to 8.5, and theTDbCachedriver tests pass locally on SQLite, MySQL, and PostgreSQL. pdo_firebird is not installed locally, so Firebird is verified in CI.testSetJoinsTheCurrentTransactionruns on Firebird with no skip: #1611 makes aTDbConnectionrollback take effect there before PHP 8.4.