Harden key-manager storage encryption key by moving to non-extractable IndexedDB CryptoKey#72
Closed
Copilot wants to merge 3 commits into
Closed
Harden key-manager storage encryption key by moving to non-extractable IndexedDB CryptoKey#72Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
vu1nz Security Review0 finding(s) in PR #? No security issues found. |
Copilot
AI
changed the title
[WIP] Fix storage encryption key exposure in localStorage
Harden key-manager storage encryption key by moving to non-extractable IndexedDB CryptoKey
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The key manager encrypted persisted conversation keys but kept the storage encryption key as raw Base64 in
localStorage, making full key recovery possible under XSS. This change removes raw key material persistence and stores the key as a non-extractable Web Crypto handle in IndexedDB.Storage key persistence hardening
KeyManagernow loads/storesqryptchat_storage_enc_keyviaindexedDBManagerinstead oflocalStorage.extractable: falseso raw bytes are not exportable.exportKey('raw')+ Base64 persistence path.Legacy key migration
localStorageorsessionStorage, it is imported as a non-extractable AES-GCM key and written to IndexedDB.Focused coverage for hardened behavior
localStoragesessionStorage